Remove support for JAVA_HOME#69149
Merged
jasontedor merged 4 commits intoelastic:masterfrom Feb 18, 2021
Merged
Conversation
This commit removes support for JAVA_HOME. As we previously deprecated usage of JAVA_HOME to override the path for the JDK, this commit follows up by removing support for JAVA_HOME. Note that we do not treat JAVA_HOME being set as a failure, as it is perfectly reasonable for a user to have JAVA_HOME configured at the system level.
jasontedor
added
>breaking
:Delivery/Packaging
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
reviewed
Feb 17, 2021
|
|
||
| *Impact* + | ||
| Use the bundled JDK (preferable), or set `ES_JAVA_HOME`. `JAVA_HOME` will | ||
| silently be ignored. |
Contributor
There was a problem hiding this comment.
This isn't true, the startup scripts will print a warning.
Member
Author
There was a problem hiding this comment.
Ah, would you be okay if we drop the word "silently" here?
mark-vieira
approved these changes
Feb 18, 2021
35 tasks
80 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes support for JAVA_HOME. As we previously deprecated usage of JAVA_HOME to override the path for the JDK, this commit follows up by removing support for JAVA_HOME. Note that we do not treat JAVA_HOME being set as a failure, as it is perfectly reasonable for a user to have JAVA_HOME configured at the system level.
Closes #55820