Skip to content

[DOCS] Note ESS must use custom bundles for custom GeoIP database files#73978

Merged
jrodewig merged 3 commits into7.13from
predogma-patch-1
Jun 15, 2021
Merged

[DOCS] Note ESS must use custom bundles for custom GeoIP database files#73978
jrodewig merged 3 commits into7.13from
predogma-patch-1

Conversation

@predogma
Copy link
Copy Markdown
Contributor

@predogma predogma commented Jun 9, 2021 •
edited by jrodewig
Loading

This is missing cloud context for custom databases. Need to provide note and link to the https://www.elastic.co/guide/en/cloud/current/ec-custom-bundles.html which has example specifically for GeoIP bundle and adding custom database.

@predogma
Update geoip.asciidoc
08eb3ce 
This is missing cloud context for custom databases.  Need to provide note and link to the https://www.elastic.co/guide/en/cloud/current/ec-custom-bundles.html which has example specifically for GeoIP bundle and adding custom database.
@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Jun 9, 2021
@jrodewig jrodewig added :Distributed/Ingest Node Execution or management of Ingest Pipelines >docs General docs changes v7.13.2 v7.14.0 v8.0.0 labels Jun 10, 2021
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Data Management (obsolete) DO NOT USE. This team no longer exists. labels Jun 10, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Jun 10, 2021

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Jun 10, 2021

Pinging @elastic/es-core-features (Team:Core/Features)

@jrodewig jrodewig changed the title Update geoip.asciidoc add ref to cloud bundles for adding custom database [DOCS] Note ESS must use custom bundles for custom GeoIP database files Jun 10, 2021
@jrodewig jrodewig requested a review from probakowski June 10, 2021 14:54
jrodewig
jrodewig approved these changes Jun 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @predogma. I relocated your sentence so it's alongside the directory location for self-managed deployments.

Otherwise, LGTM. I'll wait for an engineer to approve before merging in.

@jrodewig jrodewig requested a review from martijnvg June 15, 2021 13:14
martijnvg
martijnvg approved these changes Jun 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig
Copy link
Copy Markdown
Contributor

jrodewig commented Jun 15, 2021

Thanks @martijnvg.

@jrodewig jrodewig merged commit a122c8a into 7.13 Jun 15, 2021
@jrodewig jrodewig deleted the predogma-patch-1 branch June 15, 2021 13:36
This was referenced Jun 15, 2021
Merged
Merged
jrodewig added a commit that referenced this pull request Jun 15, 2021
@jrodewig @predogma
[DOCS] Note ESS must use custom bundles for custom GeoIP database fil…
c4741ab 
…es (#73978) (#74128)

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

Co-authored-by: Jennie Soria <predogma@users.noreply.github.com>
jrodewig added a commit that referenced this pull request Jun 15, 2021
@jrodewig @predogma
[DOCS] Note ESS must use custom bundles for custom GeoIP database fil…
917154b 
…es (#73978) (#74129)

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

Co-authored-by: Jennie Soria <predogma@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martijnvg martijnvg martijnvg approved these changes

@probakowski probakowski Awaiting requested review from probakowski

+1 more reviewer

@jrodewig jrodewig jrodewig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Distributed/Ingest Node Execution or management of Ingest Pipelines >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management (obsolete) DO NOT USE. This team no longer exists. Team:Docs Meta label for docs team v7.13.3 v7.14.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@predogma @elasticmachine @jrodewig @martijnvg @jakelandis @danhermann @elasticsearchmachine