Speed up Maps.copyMapWithAddedEntry to Speed up ITs (#73308)#74046
Merged
original-brownbear merged 1 commit intoelastic:7.xfrom Jun 13, 2021
original-brownbear:73308-7.x
Merged
Speed up Maps.copyMapWithAddedEntry to Speed up ITs (#73308)#74046original-brownbear merged 1 commit intoelastic:7.xfrom original-brownbear:73308-7.x
original-brownbear merged 1 commit intoelastic:7.xfrom
original-brownbear:73308-7.x
Conversation
This method is taking about 4% of CPU time with internal cluster tests for me. 80% of that were coming from the slow immutability assertion, the rest was due to the slow way we were building up the new map. The CPU time slowness likely translates into outright test slowness, because this was mainly hit through adding transport handlers when starting nodes (which happens on the main test thread). Fixed both to save a few % of test runtime.
original-brownbear
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method is taking about 4% of CPU time with internal cluster tests
for me. 80% of that were coming from the slow immutability assertion,
the rest was due to the slow way we were building up the new map.
The CPU time slowness likely translates into outright test slowness,
because this was mainly hit through adding transport handlers when starting
nodes (which happens on the main test thread).
Fixed both to save a few % of test runtime.
backport of #73308