[Rest Api Compatibility] Enable tests after types and cat api fixed#75179
Merged
pgomulka merged 8 commits intoelastic:masterfrom Jul 14, 2021
Merged
Conversation
Some tests are fixed after typed api is available with compatible api. Also cat api returning text fixed some tests
pgomulka
commented
Jul 9, 2021
pgomulka
commented
Jul 9, 2021
| ].join(',') | ||
| } | ||
| tasks.named("transformV7RestTests").configure({ task -> | ||
| task.addAllowedWarningRegex("setting \\[ecs\\] is deprecated as ECS format is the default and only option") |
Contributor
Author
There was a problem hiding this comment.
a deprecation added in 8.0, maybe we should use onOrAfter(v8) for this? https://github.com/elastic/elasticsearch/blob/master/modules/ingest-user-agent/src/main/java/org/elasticsearch/ingest/useragent/UserAgentProcessor.java#L196
pgomulka
commented
Jul 9, 2021
| 'analysis-common/40_token_filters/delimited_payload_filter_error', | ||
| 'analysis-common/20_analyzers/standard_html_strip' | ||
| ].join(',') | ||
| 'search.query/50_queries_with_synonyms/Test common terms query with stacked tokens', // #42654 - not sure, remove `common` query |
Contributor
Author
pgomulka
commented
Jul 9, 2021
| 'mtermvectors/11_basic_with_types/Basic tests for multi termvector get', | ||
| 'mtermvectors/21_deprecated_with_types/Deprecated camel case and _ parameters should fail in Term Vectors query', | ||
| 'mtermvectors/30_mix_typeless_typeful/mtermvectors without types on an index that has types', | ||
| 'search/150_rewrite_on_coordinator/Ensure that we fetch the document only once', //terms_lookup |
Contributor
Author
There was a problem hiding this comment.
already fixed, added back here by mistake due to merge conflict
…ts_after_types_and_cat_fixed
…ts_after_types_and_cat_fixed
jakelandis
approved these changes
Jul 13, 2021
Contributor
jakelandis
left a comment
jakelandis
left a comment
There was a problem hiding this comment.
LGTM. Once all of the tests we expect to pass we should remove the "v7compatibilityNotSupportedTests" array since it will be redundant.
masseyke
pushed a commit
to masseyke/elasticsearch
that referenced
this pull request
Jul 16, 2021
…lastic#75179) Some tests are fixed after typed api is available with compatible api. Also cat api returning text fixed some tests relates elastic#51816
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests are fixed after typed api is available with compatible api.
Also cat api returning text fixed some tests
relates #51816