[Rest Api Compatibility] CommonTermsQuery and cutoff_frequency param#75896
Merged
pgomulka merged 14 commits intoelastic:masterfrom Aug 5, 2021
Merged
[Rest Api Compatibility] CommonTermsQuery and cutoff_frequency param#75896pgomulka merged 14 commits intoelastic:masterfrom
pgomulka merged 14 commits intoelastic:masterfrom
Conversation
Refactoring to NamedXContentRegistry to make it easier to register new query builders. It removes the concept of separate compatibel namedXContentRegistry and adds a second dimension - restApiVersion - to registry in NamedXContentRegistry. This makes the design similar to the solution in ObjectParser where the field parser lookup map also needs has a restApiVersion relates elastic#51816
…tent_registry_for_queries
…tent_registry_for_queries
pgomulka
changed the title
pgomulka
added
the
:Search/Search
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
romseygeek
approved these changes
Aug 5, 2021
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
One nit, LGTM otherwise
|
|
||
| @Override | ||
| protected void doWriteTo(StreamOutput out) throws IOException { | ||
| } |
Contributor
There was a problem hiding this comment.
Can we throw UnsupportedOperationException here to make sure we catch inadvertent calls early?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously removed in #42654. The query and the parameter won't work under rest api compatibility and an exception with a message is returned advising that just use of match/multi_match is enough
relates #51816