Skip to content

Adding deprecation info API check for client transport profile setting#76999

Merged
masseyke merged 3 commits intoelastic:7.xfrom
masseyke:feature/deprecation-info-transport-client-profiles-filter
Sep 2, 2021
Merged

Adding deprecation info API check for client transport profile setting#76999
masseyke merged 3 commits intoelastic:7.xfrom
masseyke:feature/deprecation-info-transport-client-profiles-filter

Conversation

@masseyke
Copy link
Copy Markdown
Member

In 8.0, access to the transport client has been removed, so the transport.profiles.*.xpack.security.type
setting is gone. This commit adds a deprecation info API check for this property.
Relates #42404 #43236

@masseyke masseyke requested a review from jbaiera August 26, 2021 21:45
@elasticmachine elasticmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Aug 26, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@masseyke masseyke linked an issue Aug 26, 2021 that may be closed by this pull request
80 tasks
Copy link
Copy Markdown
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending small change

ClusterState cs,
XPackLicenseState licenseState
) {
final Setting.AffixSetting<String> TRANSPORT_TYPE_PROFILE_SETTING =
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Variable casing

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, fixed.

@masseyke masseyke merged commit b95df28 into elastic:7.x Sep 2, 2021
@masseyke masseyke deleted the feature/deprecation-info-transport-client-profiles-filter branch September 2, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v7.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Deprecation Info API checks for 8.0

5 participants