Add multiple validators to FieldMapper.Parameter#77073
Merged
csoulios merged 1 commit intoelastic:masterfrom Aug 31, 2021
Merged
Add multiple validators to FieldMapper.Parameter#77073csoulios merged 1 commit intoelastic:masterfrom
FieldMapper.Parameter#77073csoulios merged 1 commit intoelastic:masterfrom
Conversation
csoulios
added
>non-issue
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
csoulios
added
the
auto-backport
Collaborator
💔 Backport failed
To backport manually run |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 31, 2021
This PR implements support for multiple validators to a FieldMapper.Parameter. The Parameter#setValidator method was replaced by Parameter#addValidator that can be called multipled times to add validation to a parameter. All validators of a parameter will be executed in the same order as they have been added and if any of them fails all validation will failed.
csoulios
added a commit
to csoulios/elasticsearch
that referenced
this pull request
Sep 1, 2021
Now that multiple validators are supported (elastic#77073) we can add a new validator instead of replacing the default param validator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements support for multiple validators to a
FieldMapper.Parameter.The
Parameter#setValidatormethod was replaced byParameter#addValidatorthat can be called multipled timesto add validation to a parameter.
All validators of a parameter will be executed in the same order as they have been added and if any of them fails all validation will failed.