Skip to content

Fix profile test #77643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nik9000 merged 1 commit into from
Sep 13, 2021
Merged

Fix profile test #77643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions server/src/test/java/org/elasticsearch/search/profile/SearchProfileResultsBuilderTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

public class SearchProfileResultsBuilderTests extends ESTestCase {
public void testFetchWithoutQuery() {
Map<SearchShardTarget, SearchProfileQueryPhaseResult> searchPhase = randomSearchPhaseResults();
Map<SearchShardTarget, SearchProfileQueryPhaseResult> searchPhase = randomSearchPhaseResults(rarely() ? 0 : between(1, 2));
FetchSearchResult fetchPhase = fetchResult(
randomValueOtherThanMany(searchPhase::containsKey, SearchProfileResultsBuilderTests::randomTarget),
null
Expand All @@ -40,7 +40,7 @@ public void testFetchWithoutQuery() {
}

public void testQueryWithoutAnyFetch() {
Map<SearchShardTarget, SearchProfileQueryPhaseResult> searchPhase = randomSearchPhaseResults();
Map<SearchShardTarget, SearchProfileQueryPhaseResult> searchPhase = randomSearchPhaseResults(between(1, 2));
FetchSearchResult fetchPhase = fetchResult(searchPhase.keySet().iterator().next(), null);
SearchProfileResults result = builder(searchPhase).build(List.of(fetchPhase));
assertThat(
Expand All @@ -51,7 +51,7 @@ public void testQueryWithoutAnyFetch() {
}

public void testQueryAndFetch() {
Map<SearchShardTarget, SearchProfileQueryPhaseResult> searchPhase = randomSearchPhaseResults();
Map<SearchShardTarget, SearchProfileQueryPhaseResult> searchPhase = randomSearchPhaseResults(between(1, 2));
List<FetchSearchResult> fetchPhase = searchPhase.entrySet()
.stream()
.map(e -> fetchResult(e.getKey(), new ProfileResult("fetch", "", Map.of(), Map.of(), 1, List.of())))
Expand All @@ -67,8 +67,7 @@ public void testQueryAndFetch() {
);
}

private static Map<SearchShardTarget, SearchProfileQueryPhaseResult> randomSearchPhaseResults() {
int size = rarely() ? 0 : randomIntBetween(1, 2);
private static Map<SearchShardTarget, SearchProfileQueryPhaseResult> randomSearchPhaseResults(int size) {
Map<SearchShardTarget, SearchProfileQueryPhaseResult> results = new HashMap<>(size);
while (results.size() < size) {
results.put(randomTarget(), SearchProfileQueryPhaseResultTests.createTestItem());
Expand Down