Merged
Conversation
elasticmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
This adds more tests copied from the our original TSDB prototype in PR elastic#75638 that are still applicable time series mode indices. There are a bunch of disabled assertions because we are not yet generating `_tsid` but the non-disabled assertions are useful. And we will soon be generating the `_tsid` so we can re-enable those assertions.
imotov
approved these changes
Sep 22, 2021
Contributor
imotov
left a comment
imotov
left a comment
There was a problem hiding this comment.
LGTM, I would only suggest removing the commented out tests or uncommenting them and placing them under skip clause. Committing such an amount of commented out code is a bit weird to me.
Member
Author
Yeah. I'm not a fan of it. I kept them in because wanted to preserve the work I'd done in the prototype so we could grab it back. But I think we don't need commented out copies. |
csoulios
approved these changes
Sep 23, 2021
Contributor
csoulios
left a comment
csoulios
left a comment
There was a problem hiding this comment.
So many tests. I love them!
LGTM.
nik9000
added
>test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds more tests copied from the our original TSDB prototype in
PR #75638 that are still applicable time series mode indices. There are
a bunch of disabled assertions because we are not yet generating
_tsidbut the non-disabled assertions are useful. And we will soon be
generating the
_tsidso we can re-enable those assertions.