Fix BulkByScrollUsesAllScrollDocumentsAfterConflictsIntegTests#79428
Merged
fcofdez merged 6 commits intoelastic:masterfrom Oct 20, 2021
Merged
Fix BulkByScrollUsesAllScrollDocumentsAfterConflictsIntegTests#79428fcofdez merged 6 commits intoelastic:masterfrom
fcofdez merged 6 commits intoelastic:masterfrom
Conversation
Since elastic#7773 was introduced, TransportBulkAction is dispatched in the Write thread pool, this changed the expectations in ordering that these test have. This commit lets the TransportBulkAction to run so the expected write ordering in the test is mantained. Closes elastic#79300
fcofdez
added
>test
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
|
I'm testing a simpler fix, I'll push it shortly |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-2 |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-2 |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
Thanks Tim! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #77731 TransportBulkAction is dispatched into the Write thread pool,
this test makes use of a deterministic task order in the data node write
thread pool. To ensure that ordering, execute the TransportBulkAction
in a coordinator node preventing that additional tasks are scheduled into
the data node write thread pool.
Closes #79300