Fix failure starting OldElasticsearch fixture with some checkout dirs#79972
Merged
mark-vieira merged 2 commits intoelastic:masterfrom Oct 28, 2021
Merged
Fix failure starting OldElasticsearch fixture with some checkout dirs#79972mark-vieira merged 2 commits intoelastic:masterfrom
mark-vieira merged 2 commits intoelastic:masterfrom
Conversation
mark-vieira
added
>non-issue
:Delivery/Build
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
Contributor
|
@elasticsearchmachine test this |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Oct 28, 2021
Collaborator
💚 Backport successful
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jenkins includes
&&in some checkout directory paths for some of our jobs. This causes issues if we then include absolute paths as command line arguments without quoting them. This fixes usages of the old elasticsearch test fixture which passes the pid directory as an absolute path via a command line argument. The fix here is just the quote the argument.Closes #79898