TSDB: Expand _id on version conflict#84957
Merged
nik9000 merged 8 commits intoelastic:masterfrom Mar 18, 2022
Merged
Conversation
Member
Author
|
I'd love to get folk's opinion on this one, especially @henningandersen. The new error message looks like: |
This adds the `_tsid` and `@timestamp` to the version conflict error message in tsdb mode. I'm trying to debug a version confict problem with tsdb and think it'd be useful to get this information rather than the generated `_id`.
nik9000
commented
Mar 15, 2022
server/src/main/java/org/elasticsearch/index/mapper/TsidExtractingIdFieldMapper.java
Outdated
Show resolved
Hide resolved
elasticmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Collaborator
|
Hi @nik9000, I've created a changelog YAML for you. |
nik9000
force-pushed
the
tsdb_version_conflict_explanation
branch
from
b7475a7 to
9fc081d
Compare
Member
Author
|
@henningandersen I think this one is ready for you. |
Contributor
henningandersen
left a comment
henningandersen
left a comment
There was a problem hiding this comment.
I would like to change the message format a bit, otherwise this looks good to me.
rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/tsdb/25_id_generation.yml
Outdated
Show resolved
Hide resolved
Member
Author
|
run elasticsearch-ci/part-1 |
Member
Author
|
Thanks folks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
_tsidand@timestampto the version conflict errormessage in tsdb mode. I'm trying to debug a version confict problem with
tsdb and think it'd be useful to get this information rather than the
generated
_id.