Test time series id in RecoverySourceHandlerTests#84996
Merged
nik9000 merged 3 commits intoelastic:masterfrom Mar 17, 2022
Merged
Test time series id in RecoverySourceHandlerTests#84996nik9000 merged 3 commits intoelastic:masterfrom
nik9000 merged 3 commits intoelastic:masterfrom
Conversation
nik9000
added
>test
elasticmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
We were just testing the standard `_id`. This converts `RecoverySourceHandlerTests` into a `MapperServiceTestCase` so it can do a "real" parse of the document which'll be very important given our future plans to make `_id` non-stored in tsdb.
Member
Author
|
run elasticsearch-ci/part-2 |
henningandersen
approved these changes
Mar 16, 2022
Contributor
henningandersen
left a comment
henningandersen
left a comment
There was a problem hiding this comment.
LGTM.
Left a couple of comments that I would like to see fixed, otherwise good.
server/src/test/java/org/elasticsearch/indices/recovery/RecoverySourceHandlerTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/indices/recovery/RecoverySourceHandlerTests.java
Outdated
Show resolved
Hide resolved
nik9000
added
auto-merge-without-approval
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Mar 17, 2022
This should be enough to detect if tsdb's `_id` field mapper changes enough to cause trouble for `Engine`. I suspect that in the end we'll need something more like the changes that elastic#84996 did for RecoverySourceHandlerTests but that's a much bigger change that I'd prefer to hold back until we need it. If tsdb's `_id` field mapper changes enough to cause trouble for `Engine`.
nik9000
added a commit
that referenced
this pull request
Mar 21, 2022
This should be enough to detect if tsdb's `_id` field mapper changes enough to cause trouble for `Engine`. I suspect that in the end we'll need something more like the changes that #84996 did for RecoverySourceHandlerTests but that's a much bigger change that I'd prefer to hold back until we need it. If tsdb's `_id` field mapper changes enough to cause trouble for `Engine`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were just testing the standard
_id. This convertsRecoverySourceHandlerTestsinto aMapperServiceTestCaseso it can doa "real" parse of the document which'll be very important given our
future plans to make
_idnon-stored in tsdb.