Conversation
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
| actions.add(RollupIndexerAction.INSTANCE); | ||
| actions.add(RollupAction.INSTANCE); | ||
| } | ||
| actions.add(RollupIndexerAction.INSTANCE); |
There was a problem hiding this comment.
Maybe adding the rollup actions can move a few lines above in the Arrays.asList() statement like everything else.
| new NamedWriteableRegistry.Entry(XPackFeatureSet.Usage.class, XPackField.ARCHIVE, ArchiveFeatureSetUsage::new) | ||
| new NamedWriteableRegistry.Entry(XPackFeatureSet.Usage.class, XPackField.ARCHIVE, ArchiveFeatureSetUsage::new), | ||
| // TSDB Downsampling / Rollup | ||
| new NamedWriteableRegistry.Entry(LifecycleAction.class, RollupILMAction.NAME, RollupILMAction::new) |
| RolloverAction.NAME, | ||
| ReadOnlyAction.NAME, | ||
| IndexSettings.isTimeSeriesModeEnabled() ? RollupILMAction.NAME : null, | ||
| RollupILMAction.NAME, |
There was a problem hiding this comment.
Please remove RollupILMAction completely from here and I will enable it in #87269
| FreezeAction.NAME, | ||
| IndexSettings.isTimeSeriesModeEnabled() ? RollupILMAction.NAME : null | ||
| ).filter(Objects::nonNull).toList(); | ||
| RollupILMAction.NAME |
There was a problem hiding this comment.
Please remove RollupILMAction completely from here and I will enable it in #87269
| new NamedXContentRegistry.Entry(LifecycleAction.class, new ParseField(RollupILMAction.NAME), RollupILMAction::parse) | ||
| ); | ||
| } | ||
| entries.add(new NamedXContentRegistry.Entry(LifecycleAction.class, new ParseField(RollupILMAction.NAME), RollupILMAction::parse)); |
There was a problem hiding this comment.
Please remove LifecycleAction completely from here and I will enable it in #87269
|
I think I may also need to remove the |
|
So I spoke with @nik9000 and we agreed that we actually want to keep the feature flag around for now, and just expose different functionalities as and when they're ready. I'll close this PR and open a new one to expose synthetic source |
3 participants
This commit makes TSDB available in 8.4.0 be default, and removes all references
to the feature flag it was previously hiding behind.