Correct assertions on profiling action cancel#92046
Merged
danielmitterdorfer merged 3 commits intoelastic:mainfrom Dec 2, 2022
Merged
Correct assertions on profiling action cancel#92046danielmitterdorfer merged 3 commits intoelastic:mainfrom
danielmitterdorfer merged 3 commits intoelastic:mainfrom
Conversation
With this commit we address two issues when testing cancellation of the profiling task: 1. We add the actual profiling task to the list of tasks to check, not only its child tasks. 2. The original test contained a race where child tasks might have been unregistered (expectedly) in between collecting tasks and checking for cancelled tasks. Now we only check all remaining tasks have been cancelled. Closes elastic#92039
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Member
|
I've muted this test for now in |
javanna
approved these changes
Dec 1, 2022
Contributor
javanna
left a comment
There was a problem hiding this comment.
LGTM thanks a lot for jumping on this.
Member
Author
|
Thanks for the review! There was one test failure in As this change is completely unrelated, the failure above is transient and all subsequent builds of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this commit we address two issues when testing cancellation of the profiling task:
Closes #92039