Skip to content

fixed link in apache RequestConfig.Builder on documentation#92073

Merged
abdonpijpelink merged 2 commits intoelastic:mainfrom
satyamkale27:link-fix
Dec 6, 2022
Merged

fixed link in apache RequestConfig.Builder on documentation#92073
abdonpijpelink merged 2 commits intoelastic:mainfrom
satyamkale27:link-fix

Conversation

@satyamkale27
Copy link
Copy Markdown
Contributor

fixed link in apache RequestConfig.Builder on documentation
_ #91945 fixes only one link , another one broken link is fixed in this pr_

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2022

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.7.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Dec 2, 2022
@satyamkale27
Copy link
Copy Markdown
Contributor Author

please take a look @abdonpijpelink

@DaveCTurner DaveCTurner added :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch >docs General docs changes and removed needs:triage Requires assignment of a team area label labels Dec 5, 2022
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Clients Meta label for clients team labels Dec 5, 2022
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/clients-team (Team:Clients)

Copy link
Copy Markdown
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satyamkale27 Thank you for fixing this. There's another broken link a bit further down - on line 215. Would you mind fixing that one too in this PR?

@satyamkale27
Copy link
Copy Markdown
Contributor Author

@abdonpijpelink yes i will fix it

@satyamkale27
Copy link
Copy Markdown
Contributor Author

Done all links are fixed now please take a look @abdonpijpelink

Copy link
Copy Markdown
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @satyamkale27 !

@abdonpijpelink abdonpijpelink merged commit e864173 into elastic:main Dec 6, 2022
abdonpijpelink pushed a commit to abdonpijpelink/elasticsearch that referenced this pull request Dec 6, 2022
…92073)

* fixed link in apache RequestConfig.Builder on documentation

* HttpAsyncClientBuilder link fixed
elasticsearchmachine pushed a commit that referenced this pull request Dec 6, 2022
…92154)

* fixed link in apache RequestConfig.Builder on documentation

* HttpAsyncClientBuilder link fixed

Co-authored-by: satyam kale <94701487+satyamkale27@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Clients Meta label for clients team Team:Docs Meta label for docs team v7.17.9 v8.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants