Deprecate an option to add different color to EuiFilterButton

[ek-so]

Is your feature request related to a problem? Please describe.
Currently it is possible to color filter buttons in whatever color option we have in the system (details here). This gives additional unnecessary flexibility and just clutters the component properties.

Describe the solution you'd like
Eliminate the options to be only "text" (black).

Desired timeline
Not urgent

[mgadewoll]

Currently EuiFilterButton accepts the following for color prop:

'text',
'accent',
'accentSecondary',
'primary',
'success',
'warning',
'danger'

@ek-so Am I understanding this correctly, that we only want to allow text as valid option?
If so, are we certain all current other usages work as expected with text variant? (the other mainly used option is primary afaik)

[mgadewoll]

the other mainly used option is primary afaik

Actually I was mistaken here, as I was thinking of EuiButtonGroup instead. From a quick check on Kibana, all usages use the default color (which is text) and there is one usage (code) that adds a backgroundBasePrimary custom background style.

[ek-so]

and there is one usage (code) that adds a backgroundBasePrimary custom background style

Hm, I can't find it to look

[JasonStoltz]

@ek-so We pulled this one to the top of our backlog. Because there is low usage, we probably won't do a true deprecation period, we'll probably just make the change in a new major version of EUI and label it as a breaking change.

[github-actions]

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.