Merged
Conversation
myasonik
approved these changes
Dec 12, 2019
Contributor
myasonik
left a comment
myasonik
left a comment
There was a problem hiding this comment.
Prop types I saw that aren't be exported:
- EuiDataGridBodyProps
- EuiDataGridCellValueProps
- EuiDataGridColumnResizerProps
- EuiDataGridHeaderRowProps
- EuiDataGridHeaderCellProps
- EuiDataGridInMemoryRendererProps
- SchemaTypeScore
I don't think any of those are required for our current API... Not sure if y'all like to publish types that wouldn't be used by consumers or not but I don't think it would hurt really and it would future proof us a little if we ever exposed APIs for any of these.
Contributor
|
Looks like these need to be further exported from datagrid/index.ts? |
Contributor
Author
Yep. If we want to go all out with exporting available types, I'm good with that. I'll update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2635
Aside from adding
EuiDataGridProps, this carries to completion only those definitions that had exports to start. If there are cases to be made for others, we can discuss here.Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes