exclude *.test.tsx? files from eui.d.ts#2673
Merged
chandlerprall merged 2 commits intoelastic:masterfrom Dec 17, 2019
Merged
Conversation
thompsongl
approved these changes
Dec 16, 2019
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Nice! This should help with #1959, also
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2671
This excludes
*.test.tsx?files when generating eui.d.ts. I verified this does not have unintended effects on Kibana by applying the change to eui@17.0.0 (Kibana's version of EUI in master), re-generating its eui.d.ts, and testing those type definitions in Kibana.Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes