[EuiText] Fix className not correctly inheriting when both color and textAlign are passed#6027
Merged
cee-chen merged 2 commits intoelastic:mainfrom Jul 5, 2022
Merged
Conversation
…`color` and `textAlign` properties are passed - unfortunately the nested `cloneElement` components appear to not be picking up children.props correctly, so we need to manually pass `className`s to ensure working className merging
thompsongl
approved these changes
Jul 5, 2022
chandlerprall
approved these changes
Jul 5, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6027/ |
Contributor
Author
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6027/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #6023
Even our own
euiTextclassName wasn't being correctly inherited. Apologies for missing this 😬Before:
After:
Checklist