[EuiPageSection] Add component prop, default to section tag#6192
Merged
cee-chen merged 4 commits intoelastic:mainfrom Aug 30, 2022
Merged
[EuiPageSection] Add component prop, default to section tag#6192cee-chen merged 4 commits intoelastic:mainfrom
component prop, default to section tag#6192cee-chen merged 4 commits intoelastic:mainfrom
Conversation
…t` tag - for layouts that need a div, aside, etc.
cee-chen
force-pushed
the
page-section-tag
branch
from
c132e48 to
ff09df9
Compare
chandlerprall
approved these changes
Aug 30, 2022
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
LGTM, those snapshots make it look like it works 😁
1Copenut
approved these changes
Aug 30, 2022
Contributor
1Copenut
left a comment
1Copenut
left a comment
There was a problem hiding this comment.
LGTM! I ran it through a quick axe scan and looked at the Accessibility tree, no outliers.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6192/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It seems incredibly bizarre to have a component named
EuiPageSectionthat doesn't actually use the<section>tag for semantic meaning.If for some reason
<section>is not applicable, we should support overriding the tag via thecomponentprop (already used as a paradigm inEuiPageTemplateto override<main>).Checklist
- [ ] Checked in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] Updated the Figma library counterpart