[EuiProvider] Configurable enforcement of provider usage#6216
[EuiProvider] Configurable enforcement of provider usage#6216chandlerprall merged 14 commits intoelastic:mainfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6216/ |
|
Pinging @chandlerprall for an early look |
This reverts commit 3c8076b.
After more thought, not sure I like this idea so much
Comfortable moving forward with the current pattern and adjusting later as needed. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6216/ |
Great call! I'll try this. |
Yep, sure does! Don't know how I missed that when I checked. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6216/ |
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; tested with the example toast in various configurations
|
@clintandrewhall Does this still look ok after the move from a global var to a module var? |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6216/ |
|
CI failures will be resolved when I revert the test docs change |
clintandrewhall
left a comment
There was a problem hiding this comment.
LGTM. We'll like follow this pattern with any Kibana context requirements.
Thanks for jumping on this so quickly! Shared UX will coordinate once this is released and in Kibana, just let us know.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6216/ |
Summary
#6210
Consumers can set a module variable to
'log','warn', or'error'with thesetEuiDevProviderWarningmethod to capture instances where components are accessing the EUI theme (viauseEuiTheme) but not usingEuiProvider.Checklist