[SearchBar] Use bool query instead of match bool logic#6220
[SearchBar] Use bool query instead of match bool logic#6220PhaedrusTheGreek merged 3 commits intoelastic:mainfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6220/ |
|
Makes sense to me. I'd like to have @chandlerprall look also as he's much more familiar with this code. |
There was a problem hiding this comment.
Code change LGTM, most of the snapshot changes LGTM (I've never been good at ES queries), @PhaedrusTheGreek would you mind verifying this snapshot DSL performs its intent?
src/components/search_bar/query/__snapshots__/ast_to_es_query_dsl.test.ts.snap
Outdated
Show resolved
Hide resolved
|
@chandlerprall @thompsongl , the snapshot DSL does look correct, aside from the unnecessary bool on a single clause, fix for which I just pushed. |
There was a problem hiding this comment.
Additional changes LGTM (nice differentiating on term count!); Needs a changelog entry, the process for creating one is at https://github.com/elastic/eui/blob/main/wiki/documentation-guidelines.md#changelog - shout if something in that doc doesn't work as expected
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6220/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6220/ |
Summary
This replaces a single match query with bool
shouldormustlogic in Query.toESQuery(). As a match query, fields with non-text mappings were failing search due to reliance on a text analyzer which doesn't exist in that case.closes #6217
Checklist