Skip to content

[Emotion] Convert EuiCode and EuiCodeBlock #6263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elizabetdev merged 22 commits into from
Oct 11, 2022
Merged

[Emotion] Convert EuiCode and EuiCodeBlock #6263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
3302f89
Splitting components and adding styles.ts files
elizabetdev Sep 26, 2022
1aee5d2
Splitting code block virtualized as a component
elizabetdev Sep 26, 2022
a3b9bea
Adjusting paddings
elizabetdev Sep 26, 2022
a67f915
Add fullscreen styles
elizabetdev Sep 26, 2022
7112db8
Fixing lint errors. Adding CL
elizabetdev Sep 27, 2022
9d7a7aa
Merge remote-tracking branch 'upstream/main' into emotion-code
elizabetdev Sep 27, 2022
3ba9cb0
Adding euiCodeSyntaxStyles to emotion global
elizabetdev Sep 30, 2022
994b8db
Merge remote-tracking branch 'upstream/main' into emotion-code
elizabetdev Sep 30, 2022
5aba9a0
Uncommenting test
elizabetdev Sep 30, 2022
5bac1e0
Remove Global Emotion CSS
cee-chen Sep 30, 2022
f3f3976
Fix code block mounted tests
cee-chen Sep 30, 2022
d5a9784
Removed unnecessary Emotion styles
elizabetdev Oct 3, 2022
95850cc
Merge remote-tracking branch 'upstream/main' into emotion-code
elizabetdev Oct 6, 2022
3795c51
Merge branch 'main' into emotion-code
cee-chen Oct 6, 2022
8dba848
Use `@emotion/css` to flatten euiCodeBlock__line CSS
cee-chen Oct 6, 2022
70aa959
[Architectural refactor]
cee-chen Oct 6, 2022
2a87474
Clean up styles further
cee-chen Oct 7, 2022
9340ccb
Clean up line CSS further
cee-chen Oct 7, 2022
8ebb108
Fix virtualized code blocks not respecting paddingSize
cee-chen Oct 7, 2022
07c3a0b
[misc] style logical property
cee-chen Oct 7, 2022
054eb76
Added `shouldRenderCustomStyles`
elizabetdev Oct 11, 2022
581b01e
Merge remote-tracking branch 'upstream/main' into emotion-code
elizabetdev Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src-docs/src/views/code/virtualized_flyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default () => {
<h2 id="flyoutTitle">A flyout with just code</h2>
</EuiTitle>
</EuiFlyoutHeader>
<div style={{ height: '100%' }}>
<div style={{ blockSize: '100%' }}>
<EuiCodeBlock
language="json"
overflowHeight={'100%'}
Expand Down
6 changes: 3 additions & 3 deletions src/components/code/__snapshots__/code.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`EuiCode renders a code snippet 1`] = `
<code
aria-label="aria-label"
class="euiCode testClass1 testClass2"
class="euiCode testClass1 testClass2 emotion-euiCode"
data-code-language="text"
data-test-subj="test subject string"
>
Expand All @@ -15,7 +15,7 @@ console.log(some);
exports[`EuiCode renders languages 1`] = `
<code
aria-label="aria-label"
class="euiCode testClass1 testClass2"
class="euiCode testClass1 testClass2 emotion-euiCode"
data-code-language="js"
data-test-subj="test subject string"
>
Expand Down Expand Up @@ -80,7 +80,7 @@ exports[`EuiCode renders languages 1`] = `
exports[`EuiCode renders transparent backgrounds 1`] = `
<code
aria-label="aria-label"
class="euiCode euiCode--transparentBackground testClass1 testClass2"
class="euiCode testClass1 testClass2 emotion-euiCode-transparentBackground"
data-code-language="text"
data-test-subj="test subject string"
>
Expand Down
Loading