Update Deployment and Devices integrations to ECS 8.16.0 (part 1) #12119
Update Deployment and Devices integrations to ECS 8.16.0 (part 1) #12119taylor-swanson wants to merge 0 commit intoelastic:mainfrom taylor-swanson:ecs/dnd-packages-8.16-part1
Conversation
🚀 Benchmarks reportTo see the full report comment with |
|
💚 Build Succeeded
|
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
dwhyrock
left a comment
There was a problem hiding this comment.
Looks like there's a hyperlink that needs some attention. I will approve once it's fixed.
packages/checkpoint/docs/README.md
Outdated
There was a problem hiding this comment.
This doesn't look correct in the rich diff.
Shouldn't it be something like [Common Vulnerabilities and Exposure CVE ID](https://cve.mitre.org/about/faqs.html#what_is_cve_id) ?
There was a problem hiding this comment.
Oh good catch.
Let me go check ECS, I didn't hand write that, that's pulled directly from the ECS definition (but this could also be an issue with how elastic-package is rendering the markdown).
There was a problem hiding this comment.
Here's the related PR: elastic/ecs#2328
The links render correctly for the ECS docs, but the syntax used for the link is not valid markdown. The integrations doc site seems to use the readme markdown more or less directly, so that will have problems, too.
For comparison, the threat fields do not use a special markup, but rather use the link directly. The ECS docs and the integration readme page in Kibana (Suricata is an example), and the integrations doc site all enrich the URL into a link. Seems like we don't need any special markup here (unless you want to hide the URL behind friendly text, but that doesn't work if it doesn't render correctly).
Unfortunately, this would need to be fixed in ECS, first. Manually fixing it here won't help, since any re-render of the readme from here will just bring the issue back. It just so happens there's an ECS meeting today. I'll bring this issue up there and see where we go from here.
|
Deferring to 8.17.0 |




Proposed commit message
Updates the following integrations to ECS 8.16.0:
Checklist
changelog.ymlfile.[ ] I have verified that any added dashboard complies with Kibana's Dashboard good practicesRelated issues