Skip to content

Update Deployment and Devices integrations to ECS 8.16.0 (part 1) #12119

Closed
taylor-swanson wants to merge 0 commit intoelastic:mainfrom
taylor-swanson:ecs/dnd-packages-8.16-part1
Closed

Update Deployment and Devices integrations to ECS 8.16.0 (part 1) #12119
taylor-swanson wants to merge 0 commit intoelastic:mainfrom
taylor-swanson:ecs/dnd-packages-8.16-part1

Conversation

@taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Dec 16, 2024

Proposed commit message

Updates the following integrations to ECS 8.16.0:

  • arista_ngfw
  • cef
  • checkpoint
  • cisco_aironet
  • cisco_asa
  • cisco_ftd
  • cisco_ios
  • cisco_ise
  • cisco_nexus
  • cisco_secure_email_gateway
  • citrix_waf

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@taylor-swanson taylor-swanson added enhancement New feature or request Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Dec 16, 2024
@taylor-swanson taylor-swanson self-assigned this Dec 16, 2024
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube
Copy link

@elasticmachine
Copy link

💚 Build Succeeded

cc @taylor-swanson

@taylor-swanson taylor-swanson marked this pull request as ready for review December 16, 2024 16:55
@taylor-swanson taylor-swanson requested a review from a team as a code owner December 16, 2024 16:55
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

Copy link
Contributor

@dwhyrock dwhyrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a hyperlink that needs some attention. I will approve once it's fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look correct in the rich diff.

Shouldn't it be something like [Common Vulnerabilities and Exposure CVE ID](https://cve.mitre.org/about/faqs.html#what_is_cve_id) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch.

Let me go check ECS, I didn't hand write that, that's pulled directly from the ECS definition (but this could also be an issue with how elastic-package is rendering the markdown).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the related PR: elastic/ecs#2328

The links render correctly for the ECS docs, but the syntax used for the link is not valid markdown. The integrations doc site seems to use the readme markdown more or less directly, so that will have problems, too.

For comparison, the threat fields do not use a special markup, but rather use the link directly. The ECS docs and the integration readme page in Kibana (Suricata is an example), and the integrations doc site all enrich the URL into a link. Seems like we don't need any special markup here (unless you want to hide the URL behind friendly text, but that doesn't work if it doesn't render correctly).

Unfortunately, this would need to be fixed in ECS, first. Manually fixing it here won't help, since any re-render of the readme from here will just bring the issue back. It just so happens there's an ECS meeting today. I'll bring this issue up there and see where we go from here.

@andrewkroh andrewkroh added Integration:arista_ngfw Arista NG Firewall (Community supported) Integration:cisco_secure_email_gateway Cisco Secure Email Gateway Integration:cef Common Event Format (CEF) Integration:cisco_ise Cisco ISE Integration:citrix_waf Citrix Web App Firewall Integration:cisco_asa Cisco ASA Integration:cisco_ios Cisco IOS Integration:checkpoint Check Point Integration:cisco_ftd Cisco FTD Integration:cisco_nexus Cisco Nexus Integration:cisco_aironet Cisco Aironet (Community supported) labels Dec 17, 2024
@taylor-swanson
Copy link
Contributor Author

Deferring to 8.17.0

@taylor-swanson taylor-swanson deleted the ecs/dnd-packages-8.16-part1 branch February 5, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:arista_ngfw Arista NG Firewall (Community supported) Integration:cef Common Event Format (CEF) Integration:checkpoint Check Point Integration:cisco_aironet Cisco Aironet (Community supported) Integration:cisco_asa Cisco ASA Integration:cisco_ftd Cisco FTD Integration:cisco_ios Cisco IOS Integration:cisco_ise Cisco ISE Integration:cisco_nexus Cisco Nexus Integration:cisco_secure_email_gateway Cisco Secure Email Gateway Integration:citrix_waf Citrix Web App Firewall Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants