Dependency version bug with plugins

[kimjoar]

I have this dep in my plugin "semver": "^5.1.0", but when running the app I get the semver specified in Kibana's package.json, namely "semver": "4.3.6". Because of a bug in semver my plugins fails.

I find this comment in the bundle built by Kibana:

// Use the define() function if we're in AMD land

which exists in 4.3.6, but not in 5.1.0.

We need to find a way to make sure plugins get the right versions of dependencies, otherwise I think we'll see lots of strange, subtle bugs.

[tylersmalley]

Any thoughts on this @spalger? Is this something you think we can fix or will it need to be apart of the re-architecture? #7322 will also resolve it once plugins are compiled outside Kibana.

[spalger]

I doubt this is still an issue, and if it is it shouldn't be... Maybe we were still using webpack's DedupePlugin at the time this was filed...

[kimjoar]

Yeah, I think the dedupe stuff was the problem back then. I'll close this issue, let's just re-open if anyone else experiences something similar