Fixing resizing for charts on dashboard for Time Series Visual Bulider#10706
Merged
simianhacker merged 1 commit intoelastic:masterfrom Mar 4, 2017
Merged
Fixing resizing for charts on dashboard for Time Series Visual Bulider#10706simianhacker merged 1 commit intoelastic:masterfrom
simianhacker merged 1 commit intoelastic:masterfrom
Conversation
simianhacker
added
Feature:Visualizations
thomasneirynck
approved these changes
Mar 4, 2017
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
I tested this by saving and reopening a few dashboards. Seems to work well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
ResizeAwaredependency and replaces it with a polling resize component that is similar to how the rest of Kibana works. The previous resize solution gave inconsistent results with saved dashboards.