[build] Use docker to manage dependencies#13347
Conversation
|
Before: |
|
I'm going to revert the change that runs this on CI so we can unblock this. For now it can be considered ease of use utility. |
ccc128d to
7055ee5
Compare
|
I would like to get this running on CI to avoid having multiple paths this could go through. I also think that getting Docker in CI will allow us to utilize it more in the future. |
|
jenkins, test it |
cf1ae79 to
2327063
Compare
CONTRIBUTING.md
Outdated
There was a problem hiding this comment.
We should note Docker being a dependency for creating builds.
92cd7f2 to
5a1c7d5
Compare
|
jenkins, test it |
|
This should be good to go now. Finally. |
There was a problem hiding this comment.
I believe there are alpine images available for this, just append -alpine.
There was a problem hiding this comment.
can't yet. the node image is based on 3.4 and rpm isn't available https://pkgs.alpinelinux.org/packages?name=rpm&branch=&repo=&arch=&maintainer=
|
I have been playing around with this off-and-on, and I am not sure about doubling the build times. Thoughts on having a task to build and publish the container to our docker repository? I am curious how much time that will shave off or how close it would get to the current build time. |
|
We could, but we'd have to remove so we don't end up with wrong versions. I'll do some timing on this and see if there's other options too. |
|
Closing until I revisit, I haven't been working on this. |
The goal of this is to move dependency management under direct control of kibana, instead of relying on the host machine.
This attempts to fix several issues:
With docker and docker-compose installed, building should work the same as it did previously.