[ui/queryBar/tests] attach $elem to DOM so "click" triggers "submit"#13544
Merged
spalger merged 1 commit intoelastic:masterfrom Aug 17, 2017
Merged
[ui/queryBar/tests] attach $elem to DOM so "click" triggers "submit"#13544spalger merged 1 commit intoelastic:masterfrom
spalger merged 1 commit intoelastic:masterfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running the tests with
npm run test:devand then accessing http://localhost:9876/debug.html I was seeing failures in the query_bar tests caused by "click" events not causing a form "submit". I'm not sure the exact scenario that triggers this but in some cases elements need to be in the DOM for things like this to happen.This change just appends the element to the DOM before compiling it and then removes it from the DOM after each test