[Maps] fix scaling and term join in product help popover width#139120
Merged
nreese merged 1 commit intoelastic:mainfrom Aug 18, 2022
Merged
[Maps] fix scaling and term join in product help popover width#139120nreese merged 1 commit intoelastic:mainfrom
nreese merged 1 commit intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
nickpeihl
approved these changes
Aug 18, 2022
Contributor
nickpeihl
left a comment
There was a problem hiding this comment.
lgtm!
code review and tested in chrome
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elastic/eui#5895 converted EuiText from CSS to Emotion. This change removed
max-width: '36em'style from EuiText.Scaling form and Term join in product help relied on this max-width setting to determine popover width. Without these, popovers look terrible as seen in image below

Chatted with EUI team about problem and they tried to solve problem in EUI, elastic/eui#6146. However, EUI determined the old behavior was a bug and Maps should set max-width
PR restores original popover look by setting max-width to what was previously set in EuiText CSS.

To test