Skip to content

[Profiling] Hide refresh button in comparison mode#140010

Merged
dgieselaar merged 1 commit intoelastic:main+profilerfrom
dgieselaar:hide-refresh-button
Sep 5, 2022
Merged

[Profiling] Hide refresh button in comparison mode#140010
dgieselaar merged 1 commit intoelastic:main+profilerfrom
dgieselaar:hide-refresh-button

Conversation

@dgieselaar
Copy link
Copy Markdown
Contributor

Before:
CleanShot 2022-09-05 at 11 55 17@2x

After:

CleanShot 2022-09-05 at 11 56 00@2x

@dgieselaar dgieselaar requested a review from a team September 5, 2022 09:56
Copy link
Copy Markdown
Contributor

@rockdaboot rockdaboot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 261.4KB 261.5KB +17.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit 75584c1 into elastic:main+profiler Sep 5, 2022
@dgieselaar dgieselaar deleted the hide-refresh-button branch September 5, 2022 10:58
@ryankeairns
Copy link
Copy Markdown
Contributor

EUI is tracking general feedback and use cases for the EuiSuperDatePicker component. No changes are imminent on the EUI side, but we do sense patterns in how implementing teams desire to use/not use the refresh button in conjunction with the date picker.

Feel free to follow along or add more use cases as you have them and we will prioritize this amongst other requests in our backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants