Skip to content

[Fleet] Remove routing path when opt-in for TSDB#148553

Merged
nchaulet merged 3 commits intoelastic:mainfrom
nchaulet:feature-remove-routing-path-tsdb
Jan 9, 2023
Merged

[Fleet] Remove routing path when opt-in for TSDB#148553
nchaulet merged 3 commits intoelastic:mainfrom
nchaulet:feature-remove-routing-path-tsdb

Conversation

@nchaulet
Copy link
Copy Markdown
Member

@nchaulet nchaulet commented Jan 9, 2023

Summary

Related to #141211 (comment)
Replace #148540

To enable TDSB we need to have at least one dimension field.
The previous code was silently failing when the stream was not containing any dimension fields, this is confusing as the user, will not know about it.

That PR change that by removing the routingPath property and relying on elasticsearch to throw if there is no dimension fields.

With a stream without dimension fields

Screen Shot 2023-01-09 at 11 25 15 AM

Otherwise

it will add the stream and index_mode timeseries to the template

Screen Shot 2023-01-09 at 11 35 45 AM

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0 labels Jan 9, 2023
@nchaulet nchaulet self-assigned this Jan 9, 2023
@nchaulet nchaulet requested a review from a team as a code owner January 9, 2023 15:36
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Jan 9, 2023

On my end, I did my tests again but added a dimension field to elastic/integrations#4749 It was in the PR but during local testing for some reasons I had it removed again and then exactly hit the issue you described. It is great that Fleet validates it to turn on the flag. But even earlier, the elastic-package should block from building the package as it is not a valid package. @elastic/ecosystem @jsoriano

@nchaulet If you agree, should we open an issue in package-spec around this?

@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Jan 9, 2023

@nchaulet If you agree, should we open an issue in package-spec around this?

Yes it will be great if elastic-package is able to catch this earlier.

@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Jan 9, 2023

@elasticmachine merge upstream

@nchaulet nchaulet requested a review from kpollich January 9, 2023 19:05
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet changed the title [Fleet] Remove routing path when option for TSDB [Fleet] Remove routing path when opt-in for TSDB Jan 9, 2023
@nchaulet nchaulet merged commit 6513706 into elastic:main Jan 9, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jan 9, 2023
@nchaulet nchaulet deleted the feature-remove-routing-path-tsdb branch January 9, 2023 21:02
jennypavlova pushed a commit to jennypavlova/kibana that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants