[Fleet] Remove routing path when opt-in for TSDB#148553
[Fleet] Remove routing path when opt-in for TSDB#148553nchaulet merged 3 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/fleet (Team:Fleet) |
|
On my end, I did my tests again but added a dimension field to elastic/integrations#4749 It was in the PR but during local testing for some reasons I had it removed again and then exactly hit the issue you described. It is great that Fleet validates it to turn on the flag. But even earlier, the elastic-package should block from building the package as it is not a valid package. @elastic/ecosystem @jsoriano @nchaulet If you agree, should we open an issue in package-spec around this? |
Yes it will be great if elastic-package is able to catch this earlier. |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @nchaulet |
Summary
Related to #141211 (comment)
Replace #148540
To enable TDSB we need to have at least one dimension field.
The previous code was silently failing when the stream was not containing any dimension fields, this is confusing as the user, will not know about it.
That PR change that by removing the routingPath property and relying on elasticsearch to throw if there is no dimension fields.
With a stream without dimension fields
Otherwise
it will add the stream and index_mode timeseries to the template