[Task Manager] remove [DOC_TYPE] from index template body#30261
Merged
tsullivan merged 3 commits intoelastic:masterfrom Feb 6, 2019
Merged
[Task Manager] remove [DOC_TYPE] from index template body#30261tsullivan merged 3 commits intoelastic:masterfrom
[DOC_TYPE] from index template body#30261tsullivan merged 3 commits intoelastic:masterfrom
Conversation
|
Ideally on 7.0+ we would instead remove |
Member
Author
That's fine. We can do a different fix for 7.0+ and 6.7. Updates coming. |
Member
Author
|
Just the 1st commit will be backported to 6.7 |
jpountz
approved these changes
Feb 6, 2019
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Member
Author
|
Test failures are known/unrelated. Kibana test server isn't able to download an 8.0.0 snapshot for Elasticsearch, as that version hasn't been published yet |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Feb 6, 2019
…stic#30261) * [Task Manager] Provide "include_type_name: true" in put template * fix for 7.0+
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Feb 6, 2019
…stic#30261) * [Task Manager] Provide "include_type_name: true" in put template * fix for 7.0+
This was referenced Feb 6, 2019
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Feb 6, 2019
…stic#30261) * [Task Manager] Provide "include_type_name: true" in put template * fix for 7.0+
tsullivan
added a commit
that referenced
this pull request
Feb 7, 2019
) (#30303) * [Task Manager] Provide "include_type_name: true" in put template * fix for 7.0+
tsullivan
added a commit
that referenced
this pull request
Feb 7, 2019
) (#30302) * [Task Manager] Provide "include_type_name: true" in put template * fix for 7.0+
[DOC_TYPE] from index template body
Contributor
💔 Build Failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starting Kibana with Task Manager enabled broke recently due to incompatibility with ES in the way it was trying to put the index template. The ES change seems to be: elastic/elasticsearch#38270
This keeps the type name in the mapping to make maintaining 6.x with backports easier.
This fixes an error when starting Kibana: