Skip to content

[es] scripts.inline -> scripts.source#30457

Merged
jbudz merged 2 commits intoelastic:masterfrom
jbudz:deprecations/scripts
Feb 25, 2019
Merged

[es] scripts.inline -> scripts.source#30457
jbudz merged 2 commits intoelastic:masterfrom
jbudz:deprecations/scripts

Conversation

@jbudz
Copy link
Copy Markdown
Contributor

@jbudz jbudz commented Feb 8, 2019

"inline" is deprecated with "source".

elastic/elasticsearch#25127

Closes #19931

@jbudz jbudz added the Team:Operations Kibana-Operations Team label Feb 8, 2019
@jbudz jbudz requested a review from a team as a code owner February 8, 2019 00:21
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Copy link
Copy Markdown
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to ML watch.js file LGTM

@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Feb 25, 2019

+@elastic/es-ui, any concerns?

@bmcconaghy
Copy link
Copy Markdown
Contributor

LGTM @jbudz

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@jbudz jbudz merged commit 01c8627 into elastic:master Feb 25, 2019
jbudz added a commit that referenced this pull request Feb 25, 2019
jbudz added a commit that referenced this pull request Feb 25, 2019
@alexwizp
Copy link
Copy Markdown
Contributor

alexwizp commented Mar 7, 2019

@jbudz @mistic @peteharverson guys, why this PR wasn't backported to 6.7? For 6.7. we also have this deprecation message

image

@tylersmalley
Copy link
Copy Markdown
Member

@jbudz would you mind backporting this to 6.7 as well?

jbudz added a commit to jbudz/kibana that referenced this pull request Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants