Skip to content

[tinymath] use the es5 build#38911

Merged
spalger merged 1 commit into
elastic:masterfrom
spalger:fix/tinymath-bwc-ie11
Jun 13, 2019
Merged

[tinymath] use the es5 build#38911
spalger merged 1 commit into
elastic:masterfrom
spalger:fix/tinymath-bwc-ie11

Conversation

@spalger
Copy link
Copy Markdown
Contributor

@spalger spalger commented Jun 13, 2019

Fixed #38857

Upgrading the tinymath library broke IE11, because the build system was rewritten and now the IE11 compatible build has to be explicitly chosen, as we're doing here with the tinymath webpack shim.

  • tested running from source in IE11

@spalger spalger added Team:Operations Kibana-Operations Team Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v8.0.0 v7.3.0 labels Jun 13, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-canvas

@spalger spalger added the release_note:skip Skip the PR/issue when compiling release notes label Jun 13, 2019
Copy link
Copy Markdown
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@cqliu1 cqliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@spalger spalger merged commit 421a941 into elastic:master Jun 13, 2019
spalger pushed a commit to spalger/kibana that referenced this pull request Jun 13, 2019
@spalger
Copy link
Copy Markdown
Contributor Author

spalger commented Jun 13, 2019

7.x/7.3: c0eba77

@spalger spalger deleted the fix/tinymath-bwc-ie11 branch June 13, 2019 21:57
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.3.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Canvas] tinymath preventing Kibana from starting in IE11

5 participants