[ML] Data frame transforms: Fix getting nested properties.#43262
Merged
walterra merged 3 commits intoelastic:masterfrom Aug 14, 2019
Merged
[ML] Data frame transforms: Fix getting nested properties.#43262walterra merged 3 commits intoelastic:masterfrom
walterra merged 3 commits intoelastic:masterfrom
Conversation
walterra
added
bug
walterra
requested review from
alvarezmelissa87,
jgowdyelastic and
peteharverson
Contributor
|
Pinging @elastic/ml-ui |
jgowdyelastic
approved these changes
Aug 14, 2019
Member
jgowdyelastic
left a comment
jgowdyelastic
left a comment
There was a problem hiding this comment.
nice util function! LGTM
Contributor
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Aug 14, 2019
…3262) - Fixes a regression where values were not properly extracted from nested objects. - Moves inline code we had to solve this to a utility function getNestedProperty(). Kibana's idx is a lodash-get replacement with TypeScript support. However, it requires that you'd know the accessor up front, it doesn't work with dynamic string values. getNestedProperty() allows you to pass a string like lodash-get, but it uses idx on the inside so you still get TypeScript support.
walterra
added a commit
that referenced
this pull request
Aug 14, 2019
…43273) - Fixes a regression where values were not properly extracted from nested objects. - Moves inline code we had to solve this to a utility function getNestedProperty(). Kibana's idx is a lodash-get replacement with TypeScript support. However, it requires that you'd know the accessor up front, it doesn't work with dynamic string values. getNestedProperty() allows you to pass a string like lodash-get, but it uses idx on the inside so you still get TypeScript support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #42117.
getNestedProperty(). Kibana'sidxis a lodash-get replacement with TypeScript support. However, it requires that you'd know the accessor up front, it doesn't work with dynamic string values.getNestedProperty()allows you to pass a string like lodash-get, but it usesidxon the inside so you still get TypeScript support.Checklist
For maintainers