Fix mislabeled range filters with scripted fields#4708
Closed
lukasolson wants to merge 1 commit intoelastic:masterfrom
Closed
Fix mislabeled range filters with scripted fields#4708lukasolson wants to merge 1 commit intoelastic:masterfrom
lukasolson wants to merge 1 commit intoelastic:masterfrom
Conversation
Contributor
Author
|
Hold off on this for now. |
Contributor
Author
|
Superseded by #4751. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4696.
When you create a filter from a histogram or range on a scripted field, the label comes out as scripted_field: "".
This was happening because there is different logic when creating a filter for a scripted field vs. a regular field. A regular field will result in
filter.rangebeing set, while a scripted field will result infilter.script.paramsbeing set, but notfilter.rangeas with normal fields. So, when the filter is read and mapped, only thefilter.rangeproperty was being checked (there was no additional logic for scripted fields). This PR addresses it by checkingfilter.script.paramsfor the associated range fields.