Skip to content

Empty message "No data available" for Labels and User metadata sections missing #49846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cauemarcondes merged 3 commits into from
Nov 14, 2019
Merged

Empty message "No data available" for Labels and User metadata sections missing #49846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19cdf7c
Adding missing data message when sections are required
cauemarcondes Oct 31, 2019
98ae5e8
refactoring test
cauemarcondes Nov 6, 2019
777e56c
fixing unit test
cauemarcondes Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions x-pack/legacy/plugins/apm/public/components/shared/MetadataTable/Section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,18 @@
*/

import React from 'react';
import { isEmpty } from 'lodash';
import { i18n } from '@kbn/i18n';
import { EuiText } from '@elastic/eui';
import { KeyValueTable } from '../KeyValueTable';
import { KeyValuePair } from '../../../utils/flattenObject';

interface Props {
keyValuePairs?: KeyValuePair[];
keyValuePairs: KeyValuePair[];
}

export function Section({ keyValuePairs }: Props) {
if (keyValuePairs) {
if (!isEmpty(keyValuePairs)) {
return <KeyValueTable keyValuePairs={keyValuePairs} />;
}
return (
Expand Down
4 changes: 2 additions & 2 deletions x-pack/legacy/plugins/apm/public/components/shared/MetadataTable/__test__/Section.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { expectTextsInDocument } from '../../../../utils/testHelpers';

describe('Section', () => {
it('shows "empty state message" if no data is available', () => {
const output = render(<Section />);
expectTextsInDocument(output, ['No data available']);
const component = render(<Section keyValuePairs={[]} />);
expectTextsInDocument(component, ['No data available']);
});
});