Allow chromeless applications to render via non-/app routes#51527
Merged
eliperelman merged 4 commits intoelastic:masterfrom Dec 29, 2019
Merged
Allow chromeless applications to render via non-/app routes#51527eliperelman merged 4 commits intoelastic:masterfrom
eliperelman merged 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
Contributor
💔 Build Failed |
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
src/core/server/application/application_context_provider.test.ts
Outdated
Show resolved
Hide resolved
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
mshustov
reviewed
Nov 25, 2019
09aca09 to
a817167
Compare
Contributor
|
retest |
joshdover
approved these changes
Dec 12, 2019
a817167 to
036d3c4
Compare
Contributor
Author
|
retest |
9d0199d to
c0eada9
Compare
c0eada9 to
595b561
Compare
Member
|
Removing review request for @elastic/kibana-security since it doesn't look like this touches anything we own. Let me know if you'd still like a review! |
595b561 to
0bd62f2
Compare
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
eliperelman
added a commit
to eliperelman/kibana
that referenced
this pull request
Dec 29, 2019
…51527) * Allow chromeless applications to render via non-/app routes * Address review nits * Fix chrome:application integration tests * Move extraneous application integration tests to unit tests
eliperelman
added a commit
that referenced
this pull request
Dec 29, 2019
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 30, 2019
* master: Allow chromeless applications to render via non-/app routes (elastic#51527) Add server rendering service to enable standalone route rendering (elastic#52161)
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 30, 2019
…le-saved-objects * 'master' of github.com:elastic/kibana: (250 commits) Allow chromeless applications to render via non-/app routes (elastic#51527) Add server rendering service to enable standalone route rendering (elastic#52161) Possibility to filter when testing scripted fields (elastic#35379) (elastic#44220) Update maps telemetry mappings to account for recent updates (elastic#53803) [Maps] Only show legend when layer is visible (elastic#53781) remove use of experimental fs.promises api (elastic#53346) [APM] Add log statements for flaky test (elastic#53775) [APM] Transaction page throws unhandled exception if transactions doesn't have `http.request` (elastic#53760) Licensing plugin functional tests (elastic#53580) [Lens] Disable saving visualization until there are no changes to the document (elastic#52982) [Monitoring] Added safeguard for some EUI components (elastic#53318) [Vega] Shim new platform - cleanup vega_visualization dependencies (elastic#53605) Display changed field formats without requiring hard page refresh. (elastic#53746) Upgrade EUI to v17.3.1 (elastic#53655) [APM] Fix missing apm indicies (elastic#53541) Disable inspector for timelion (elastic#53747) Clean up search servie (elastic#53701) [Dashboard] Grid: removing double handler (elastic#53707) Remove SavedObjectRegistryProvider from codebase (elastic#53455) Move ui/courier into data shim plugin (elastic#52359) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 2, 2020
…ris/kibana into alerting/created_at-and-updated_at * 'alerting/created_at-and-updated_at' of github.com:gmmorris/kibana: Allow chromeless applications to render via non-/app routes (elastic#51527) Add server rendering service to enable standalone route rendering (elastic#52161)
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 8, 2020
…51527) * Allow chromeless applications to render via non-/app routes * Address review nits * Fix chrome:application integration tests * Move extraneous application integration tests to unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows applications to be rendered independently of using
/approutes. Updates the frontend application service to make apps routable viaappRouteduring registration.appRoutein the routing components, we need to pass more than just a mount function. Going down this route made me realize that if we re-structured the order of when we load the necessary app service bits, and doing a state-lift with much of the data, we could co-locate all the business logic in the app service, make the implementation simpler, and also easier to test while expanding the test coverage.getValues, so I simplified to just unwrap them to their maps.FunctionComponent, so I took the opportunity to update the relevant components to follow suit.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportThis was checked for keyboard-only and screenreader accessibilityFor maintainers
Dev Docs
Allow applications to routable from paths that do not start with
/app. This is first enabled via theappRouteflag during UI application registration: