Closed
Conversation
chrisronline
added
release_note:fix
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
Contributor
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
Contributor
|
Closing in favor of #52834 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#48568 introduced a change which I think has negatively affected maps telemetry.
It makes sense to remove
task_manageras a hard dependency, but the maps plugin still needs it as a soft dependency (since it relies on it for telemetry purposes). Kibana has a way to handle soft dependencies, which maps is currently using. Unfortunately, this particular code is preventing that code from every executing.The reason we are not seeing an error is because our isReady check for task manager is too naive (#52446 should fix this problem) and returns a success even though the task was never scheduled! As a result, I don't think maps is sending telemetry data right now.
As I fixed this, I found other issues that suggest telemetry data is broken (missing mappings from the telemetry file)
cc @thomasneirynck @wylieconlon