[Vis: Default editor] Reactify the timelion editor by sulemanof · Pull Request #52990 · elastic/kibana

sulemanof · 2019-12-13T13:35:26Z

Summary

Convert the Timelion vis editor to React/Typescript.

The PR includes:

move expression input editor to the common CodeEditor based on Monaco editor API;
add type to pegjs parser;
add validation to the Interval input (empty field restricted);

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

…ns/timelion

sulemanof · 2019-12-13T15:05:55Z

@elasticmachine merge upstream

…ns/timelion

…ibana into EUIfication/options/timelion

elasticmachine · 2019-12-17T13:42:32Z

Pinging @elastic/kibana-app (Team:KibanaApp)

…ns/timelion # Conflicts: # src/legacy/core_plugins/timelion/server/types.ts

flash1293 · 2019-12-17T15:46:22Z

Maybe that's inherent to the monaco editor, but when auto-completing a field name, it has some strange handling for values containing a trigger character like . themselves: In this recording I'm hitting ctrl+space, then enter twice:

The first autocomplete makes total sense, but the second one shouldn't happen. It doesn't happen when there are no dots in the autocompleted value (again pressed ctrl+space, then enter twice):

flash1293

Looks pretty good already, left some minor comments

src/legacy/core_plugins/timelion/public/components/timelion_expression_input.tsx

src/legacy/core_plugins/timelion/public/vis/index.tsx

src/legacy/core_plugins/timelion/public/components/timelion_interval.tsx

src/legacy/core_plugins/timelion/public/vis/_timelion_editor.scss

lizozom

Code owner changes (settings languageConfiguration on code_editor) seem OK.
Didn't checkout locally.

src/legacy/core_plugins/timelion/public/components/timelion_expression_input.tsx

…ns/timelion

sulemanof · 2019-12-21T14:48:43Z

The Inspector thing is broken on master, I've prepared the fix separately #53747

kibanamachine · 2019-12-21T15:02:58Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 2091a0c

History

💚 Build #16876 succeeded 3cf416f
💚 Build #16709 succeeded a691c12
💚 Build #16641 succeeded f640b05
💔 Build #16075 failed bcf36c6
💚 Build #15731 succeeded 73fbc38

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2019-12-21T16:22:16Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 051f43b8e440c1f34beb47375bdfaa23bcdef1aa

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ns/timelion

flash1293

Code LGMT, @alexwizp s comment about the PEG file is definitely valid, but I don't consider it a blocker for this PR. If this is easy to add we should probably do it, but I'm fine with doing it in a separate PR.

…ns/timelion # Conflicts: # renovate.json5

maryia-lapata

LGTM, tested locally.

cchaos

Pushed a couple SASS scheme fixes. Thanks for addressing those other issues.

kibanamachine · 2020-01-08T20:48:21Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5887a92

History

💚 Build #18643 succeeded f3a6df8
💔 Build #18621 failed 474d14e
💚 Build #17149 succeeded 1a2d283

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Reactify timelion editor * Change translation ids * Add @types/pegjs into renovate.json5 * Add validation, add hover suggestions * Style fixes * Change plugin setup, use kibana context * Change plugin start * Mock services * Fix other comments * Build renovate config * Fix some classnames and SASS file structure Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> # Conflicts: # renovate.json5

* master: (23 commits) [Vis: Default editor] Reactify the timelion editor (elastic#52990) [Discover] fix histogram min interval (elastic#53979) [Telemetry] [Monitoring] Only retry fetching usage once monito… (elastic#54309) [docs][APM] Add runtime index config documentation (elastic#53907) [SIEM] Detection engine timeline (elastic#53783) Filter scripted fields preview field list to source fields (elastic#53826) Management - New platform api (elastic#52579) Reset region and Account when switching inventory (elastic#54287) [SIEM] [Case] Case workflow api schema (elastic#51535) Code coverage setup on CI (elastic#49003) [ML] DF Analytics Results: adds link to docs (elastic#54189) Update schemas boolean, byteSize, and duration to coerce strings (elastic#54177) [Metrics UI] Pass relevant shouldAllowEdit capabilities into SettingsPage (elastic#49781) [Canvas] Fixes bugs with autoplay and refresh (elastic#53149) [ML] DF Analytics Classification: ensure confusion matrix can be fetched (elastic#53629) Fix Vega react eslint errors (elastic#54259) Remove non existing codeowners (elastic#54274) use correct type (elastic#54244) [Dashboard] Removing 100% as dshDashboardViewport height (elastic#54263) add `examples/` to no-restricted-path config (elastic#54252) ...

* Reactify timelion editor * Change translation ids * Add @types/pegjs into renovate.json5 * Add validation, add hover suggestions * Style fixes * Change plugin setup, use kibana context * Change plugin start * Mock services * Fix other comments * Build renovate config * Fix some classnames and SASS file structure Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> # Conflicts: # renovate.json5

Reactify timelion editor

8287a0e

sulemanof requested review from alexwizp and maryia-lapata December 13, 2019 13:35

timroes mentioned this pull request Dec 13, 2019

EUIficate visualization option panels #38273

Closed

10 tasks

sulemanof added 2 commits December 13, 2019 17:18

Change translation ids

b390d1d

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

df7dc2d

…ns/timelion

elasticmachine and others added 6 commits December 13, 2019 07:06

Merge branch 'master' into EUIfication/options/timelion

78bd381

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

6f10b86

…ns/timelion

Merge branch 'EUIfication/options/timelion' of github.com:sulemanof/k…

c35088b

…ibana into EUIfication/options/timelion

Add @types/pegjs into renovate.json5

6a600b0

Add validation, add hover suggestions

73fbc38

Style fixes

40400bc

sulemanof changed the title ~~Reactify timelion editor~~ [Vis: Default editor] Reactify the timelion editor Dec 17, 2019

sulemanof requested review from cchaos and flash1293 December 17, 2019 13:41

sulemanof marked this pull request as ready for review December 17, 2019 13:41

sulemanof requested review from a team as code owners December 17, 2019 13:41

sulemanof added Feature:Timelion Timelion app and visualization Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.7.0 v8.0.0 labels Dec 17, 2019

sulemanof added the release_note:skip Skip the PR/issue when compiling release notes label Dec 17, 2019

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

bcf36c6

…ns/timelion # Conflicts: # src/legacy/core_plugins/timelion/server/types.ts

flash1293 reviewed Dec 17, 2019

View reviewed changes

lizozom approved these changes Dec 17, 2019

View reviewed changes

lizozom reviewed Dec 17, 2019

View reviewed changes

src/legacy/core_plugins/timelion/public/components/timelion_expression_input.tsx Outdated Show resolved Hide resolved

sulemanof added 2 commits December 21, 2019 13:33

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

8f2101e

…ns/timelion

Change plugin start

2091a0c

elastic deleted a comment from elasticmachine Dec 21, 2019

sulemanof added 3 commits December 23, 2019 11:57

Mock services

daf056e

Fix other comments

21bd6d6

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

1a2d283

…ns/timelion

sulemanof force-pushed the EUIfication/options/timelion branch from 051f43b to 1a2d283 Compare December 23, 2019 13:29

sulemanof requested review from cchaos, flash1293 and maryia-lapata December 23, 2019 13:33

flash1293 approved these changes Dec 30, 2019

View reviewed changes

maryia-lapata mentioned this pull request Jan 4, 2020

[Vis] Move Timelion Vis to vis_type_timelion #52069

Merged

2 tasks

sulemanof added 2 commits January 8, 2020 11:26

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

474d14e

…ns/timelion # Conflicts: # renovate.json5

Build renovate config

f3a6df8

maryia-lapata approved these changes Jan 8, 2020

View reviewed changes

Fix some classnames and SASS file structure

5887a92

cchaos approved these changes Jan 8, 2020

View reviewed changes

sulemanof merged commit ecddfd8 into elastic:master Jan 9, 2020

sulemanof deleted the EUIfication/options/timelion branch January 9, 2020 08:00

sulemanof added v7.6.0 and removed v7.7.0 labels Jan 9, 2020

sulemanof mentioned this pull request Jan 9, 2020

[7.x] [Vis: Default editor] Reactify the timelion editor (#52990) #54329

Merged

sulemanof added the backported label Jan 9, 2020

Conversation

sulemanof commented Dec 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

sulemanof commented Dec 13, 2019

Uh oh!

elasticmachine commented Dec 17, 2019

Uh oh!

flash1293 commented Dec 17, 2019

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sulemanof commented Dec 21, 2019

Uh oh!

kibanamachine commented Dec 21, 2019

💔 Build Failed

History

Uh oh!

kibanamachine commented Dec 21, 2019

💔 Build Failed

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

maryia-lapata left a comment

Choose a reason for hiding this comment

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jan 8, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

sulemanof commented Dec 13, 2019 •

edited

Loading