Skip to content

[Uptime] Fix Telemetry Api flaky test#67358

Merged
shahzad31 merged 6 commits intoelastic:masterfrom
shahzad31:api-flaky-test
Jun 4, 2020
Merged

[Uptime] Fix Telemetry Api flaky test#67358
shahzad31 merged 6 commits intoelastic:masterfrom
shahzad31:api-flaky-test

Conversation

@shahzad31
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 commented May 26, 2020 •
edited
Loading

@shahzad31 shahzad31 requested a review from a team as a code owner May 26, 2020 15:31
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label May 26, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 26, 2020

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 self-assigned this May 26, 2020
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 labels May 26, 2020
@shahzad31
Copy link
Copy Markdown
Contributor Author

shahzad31 commented May 26, 2020

@elasticmachine merge upstream

@shahzad31
Copy link
Copy Markdown
Contributor Author

shahzad31 commented May 29, 2020

@elasticmachine merge upstream

@shahzad31
Copy link
Copy Markdown
Contributor Author

shahzad31 commented Jun 2, 2020

@elasticmachine merge upstream

@spalger spalger added the v7.8.0 label Jun 2, 2020
@spalger
Copy link
Copy Markdown
Contributor

spalger commented Jun 2, 2020

@shahzad31 FYI, I needed to skip this in 7.8 as well so please make sure to backport all the way to 7.8

@spalger spalger mentioned this pull request Jun 2, 2020
Closed
justinkambic
justinkambic approved these changes Jun 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you ran this on flaky test runner to verify it right?

@shahzad31
Copy link
Copy Markdown
Contributor Author

shahzad31 commented Jun 3, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 3, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 8e74275 into elastic:master Jun 4, 2020
@shahzad31 shahzad31 deleted the api-flaky-test branch June 4, 2020 08:55
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 4, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
541a871 
* master: (26 commits)
  [Console]remove completion for type for filter queries and aggs (elastic#68103)
  [ML] Transforms: Filter aggregation support (elastic#67591)
  [ES UI Shared] Monaco XJSON (elastic#67485)
  [Index Management] Add data streams functionality to indices tab (elastic#67940)
  [Discover] Fix renaming of saved search not displayed in breadcrumb (elastic#67577)
  [SECURITY] Rename siem plugin to security_solution (elastic#67902)
  [Uptime] Fix Telemetry Api flaky test (elastic#67358)
  [Data plugin] Add configuration property to enable / disable autocomplete (elastic#67847)
  remove scripts. prettire update has been done (elastic#68130)
  Closes elastic#68055 by detecting the local Kibana version and using that as (elastic#68198)
  [apm] docs: add deployment annotation example (elastic#67408)
  [ML] Extend population preview chart to show actual and typical value (elastic#67569)
  Refactor index management client integration tests for scalability (elastic#67917)
  Add generator function that creates multiple alerts (elastic#67713)
  chore(NA): remove config arg from os packages (elastic#67871)
  [Reporting] Move code out of Legacy (elastic#67904)
  [Metrics UI] Add overrides to Snapshot API to support alert previews (elastic#68125)
  [Security] [Cases] Manage timeline UI API (elastic#67719)
  [ENDPOINT][INGEST]Task/endpoint ingest update (elastic#67234)
  Fix code coverage for jest, upload merged reports (elastic#68149)
  ...
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 8, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 67358 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 8, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 9, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 67358 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 10, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 67358 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 11, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 67358 or prevent reminders by adding the backport:skip label.

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Jun 11, 2020
@shahzad31 @elasticmachine
[Uptime] Fix Telemetry Api flaky test (elastic#67358)
bd1ab25 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@shahzad31 shahzad31 mentioned this pull request Jun 11, 2020
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 12, 2020

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 13, 2020
shahzad31 added a commit that referenced this pull request Jun 13, 2020
@shahzad31 @elasticmachine
[7.x] [Uptime] Fix Telemetry Api flaky test (#67358) (#68877)
e7e6e06 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees

@shahzad31 shahzad31

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.8.0 v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

5 participants

@shahzad31 @elasticmachine @spalger @kibanamachine @justinkambic