[7.x] [ES UI Shared] Monaco XJSON (#67485)#68234
Merged
jloleysens merged 1 commit intoelastic:7.xfrom Jun 4, 2020
Merged
Conversation
* First iteration of xjson in monaco * Throwaway implementation in painless lab - THIS MUST BE REVERTED * WiP on build process for new kbn-lang package * new @kbn/langs package and update ui-shared-deps * Update jest config for new work files * Update painless lab -- REVERT THIS COMMIT * Create shared useXJson mode hook * Final update to using the new shared useXJsonMode hook -- REVERT * Created @kbn/monaco and share through shared deps * always access monaco through `@kbn/monaco` * use path.resolve to create path * add basic readme * remove console.log call * remove typescript support from ui-shared-deps webpack config * use `@kbn/babel-preset` * include the monaco styles in the kbn-ui-shared-deps * sort package.json * build worker at bootstrap rather than commiting to repo * only build worker, don't pre-bundle monaco * fix type check errors * remove section from readme about committed dist * keep editor.worker.js postfix * forgot to save update to import * license package as apache-2.0 * Added regenerator runtime for worker bundle * revert changes to painless lab Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: