Skip to content

[7.x] [APM] Storybook theme fixes (#69730)#69794

Merged
smith merged 1 commit intoelastic:7.xfrom
smith:backport/7.x/pr-69730
Jun 24, 2020
Merged

[7.x] [APM] Storybook theme fixes (#69730)#69794
smith merged 1 commit intoelastic:7.xfrom
smith:backport/7.x/pr-69730

Conversation

@smith
Copy link
Copy Markdown
Contributor

@smith smith commented Jun 24, 2020

Backports the following commits to 7.x:

* [APM] Storybook theme fixes

The changes adding theme support in elastic#69362 broke some of the Storybook stories.

Add decorators to wrap some of the stories in the theme context.

This should be done in a global decorator, but our current storybook setup doesn't support this. It also would be nice to be able to switch between light/dark mode, but that's something we can add in the future.

* Remove unused import

* Adds missing decorator to cytoscape examples + adds a new real-world example

Co-authored-by: Oliver Gupte <olivergupte@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@smith smith added the backport This PR is a backport of another PR label Jun 24, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit ce693b0 into elastic:7.x Jun 24, 2020
@smith smith deleted the backport/7.x/pr-69730 branch June 24, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants