[Security Solution][Timeline] Fix timeline styling and createFrom beh… by patrykkopycinski · Pull Request #72152 · elastic/kibana

patrykkopycinski · 2020-07-16T20:08:10Z

…avior

Summary

Fixes behavior of createTimelineFrom actions and adds tests to make sure it works as expected

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…avior

elasticmachine · 2020-07-16T20:08:12Z

Pinging @elastic/siem (Team:SIEM)

XavierM · 2020-07-16T20:11:55Z

.../plugins/security_solution/public/timelines/components/open_timeline/use_timeline_status.tsx

-  const [selectedTab, setSelectedTab] = useState<TemplateTimelineTypeLiteralWithNull>(
-    TemplateTimelineType.elastic
-  );
+  const [selectedTab, setSelectedTab] = useState<TemplateTimelineTypeLiteralWithNull>(null);


patrykkopycinski · 2020-07-17T07:15:23Z

@elasticmachine merge upstream

…create-from-action

angorayc · 2020-07-20T11:54:10Z

x-pack/plugins/security_solution/server/lib/timeline/saved_object.ts

-  const filters = enableElasticFilter
-    ? [typeFilter, draftFilter, immutableFilter, templateTimelineTypeFilter]
-    : [typeFilter, draftFilter, immutableFilter];
+  const filters = [typeFilter, draftFilter, immutableFilter, templateTimelineTypeFilter];


angorayc · 2020-07-20T13:54:33Z

x-pack/plugins/security_solution/public/timelines/components/open_timeline/helpers.ts

-  // TODO: MOVE TO BACKEND
-  return uuid.v4();
+  return duplicate && timeline.timelineType === TimelineType.template
+    ? // TODO: MOVE TO THE BACKEND


The reason why I did it here was to fix templateTimelineId was not available until the request came back.
If we move this to server side may cause update failure if users updating timeline continuously in a short time. Means the follow up request might have sent before the first one come back with a templateTimelineId.

kibanamachine · 2020-07-20T14:04:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ffea0c5

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	7.3MB	+709.0B	7.3MB

page load bundle size

id	value	diff	baseline
securitySolution	870.1KB	-18.0B	870.1KB

History

💚 Build #62865 succeeded c34119b
💔 Build #62727 failed 35ba4b3
💔 Build #62684 failed 12f1761
💚 Build #62580 succeeded 4605896
💔 Build #62561 failed 3eda4d0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elastic#72152)

#72152) (#72440)

#72152) (#72439)

stephmilovic · 2020-07-20T17:08:00Z

closes https://github.com/elastic/siem-team/issues/749

* master: (60 commits) [SIEM][Detection Engine][Lists] Adds list permissions (elastic#72335) [SIEM][Detection Engine][Lists] Adds conflict versioning and io-ts improvements to lists (elastic#72337) [Resolver] no longer pass related event stats to process node component (elastic#72435) Revert "skip flaky suite (elastic#72146)" [Security Solution] Cleanup endpoint telemetry (elastic#71950) Unskip dashboard embeddable rendering tests (elastic#71824) [ENDPOINT] Added unerolling status for host. (elastic#72303) [Alerting][Connectors] Increase the size of the logos (elastic#72419) [SECURITY] [Timeline] Raw events not displayed (elastic#72387) [ML] Fixes display of regression stop stats if one is NaN (elastic#72412) [Ingest Pipelines] Processor Editor Move Tooltip (elastic#72239) Fix match phrase and not match phrase comparators (elastic#71850) [Plugin Generator] Generate tsconfig and useDefaultBehaviors (elastic#72040) [Security Solution][Timeline] Fix timeline styling and createFrom beh… (elastic#72152) [Resolver] Selector performance (elastic#72380) [Ingest Manager] Set `_meta` in the index.mappings (elastic#72026) [Ingest Manager] Do not bumb config revision during config creation (elastic#72270) [ML] Adding missing index pattern name to new job wizards (elastic#72400) [ML] improve annotation flyout performance (elastic#72299) [APM] Testing error rate API and restructuring folders (elastic#72257) ...

* master: (26 commits) [SIEM][Detection Engine][Lists] Adds list permissions (elastic#72335) [SIEM][Detection Engine][Lists] Adds conflict versioning and io-ts improvements to lists (elastic#72337) [Resolver] no longer pass related event stats to process node component (elastic#72435) Revert "skip flaky suite (elastic#72146)" [Security Solution] Cleanup endpoint telemetry (elastic#71950) Unskip dashboard embeddable rendering tests (elastic#71824) [ENDPOINT] Added unerolling status for host. (elastic#72303) [Alerting][Connectors] Increase the size of the logos (elastic#72419) [SECURITY] [Timeline] Raw events not displayed (elastic#72387) [ML] Fixes display of regression stop stats if one is NaN (elastic#72412) [Ingest Pipelines] Processor Editor Move Tooltip (elastic#72239) Fix match phrase and not match phrase comparators (elastic#71850) [Plugin Generator] Generate tsconfig and useDefaultBehaviors (elastic#72040) [Security Solution][Timeline] Fix timeline styling and createFrom beh… (elastic#72152) [Resolver] Selector performance (elastic#72380) [Ingest Manager] Set `_meta` in the index.mappings (elastic#72026) [Ingest Manager] Do not bumb config revision during config creation (elastic#72270) [ML] Adding missing index pattern name to new job wizards (elastic#72400) [ML] improve annotation flyout performance (elastic#72299) [APM] Testing error rate API and restructuring folders (elastic#72257) ...

…feature-privileges * alerting/consumer-based-rbac: (45 commits) fixed alerts test [SIEM][Detection Engine][Lists] Adds list permissions (elastic#72335) [SIEM][Detection Engine][Lists] Adds conflict versioning and io-ts improvements to lists (elastic#72337) [Resolver] no longer pass related event stats to process node component (elastic#72435) Revert "skip flaky suite (elastic#72146)" [Security Solution] Cleanup endpoint telemetry (elastic#71950) Unskip dashboard embeddable rendering tests (elastic#71824) [ENDPOINT] Added unerolling status for host. (elastic#72303) [Alerting][Connectors] Increase the size of the logos (elastic#72419) [SECURITY] [Timeline] Raw events not displayed (elastic#72387) [ML] Fixes display of regression stop stats if one is NaN (elastic#72412) [Ingest Pipelines] Processor Editor Move Tooltip (elastic#72239) Fix match phrase and not match phrase comparators (elastic#71850) [Plugin Generator] Generate tsconfig and useDefaultBehaviors (elastic#72040) [Security Solution][Timeline] Fix timeline styling and createFrom beh… (elastic#72152) allow user to disable alert even if they dont have privileges to the underlying action [Resolver] Selector performance (elastic#72380) [Ingest Manager] Set `_meta` in the index.mappings (elastic#72026) [Ingest Manager] Do not bumb config revision during config creation (elastic#72270) [ML] Adding missing index pattern name to new job wizards (elastic#72400) ...

elasticmachine · 2021-09-23T14:29:35Z

Pinging @elastic/security-solution (Team: SecuritySolution)

[Security Solution][Timeline] Fix timeline styling and createFrom beh…

e2d1e74

…avior

patrykkopycinski added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 16, 2020

patrykkopycinski requested review from XavierM, andrew-goldstein and angorayc July 16, 2020 20:08

patrykkopycinski requested review from a team as code owners July 16, 2020 20:08

patrykkopycinski self-assigned this Jul 16, 2020

XavierM reviewed Jul 16, 2020

View reviewed changes

Fix types

dd53ace

elasticmachine and others added 8 commits July 17, 2020 01:15

Merge branch 'master' into fix/timeline-create-from-action

626d956

Fix API

3eda4d0

Merge branch 'master' of github.com:elastic/kibana into fix/timeline-…

1d03ac7

…create-from-action

Fix API

4605896

Fix dataproviders

12f1761

Merge branch 'master' of github.com:elastic/kibana into fix/timeline-…

35ba4b3

…create-from-action

Merge branch 'master' of github.com:elastic/kibana into fix/timeline-…

ac3e622

…create-from-action

update tests

c34119b

angorayc reviewed Jul 20, 2020

View reviewed changes

patrykkopycinski added 2 commits July 20, 2020 14:09

Fix duplicate saving

1d8a50f

Save excludedRowRenderersId settings

ffea0c5

angorayc reviewed Jul 20, 2020

View reviewed changes

angorayc approved these changes Jul 20, 2020

View reviewed changes

patrykkopycinski merged commit 7ac5fc4 into elastic:master Jul 20, 2020

patrykkopycinski deleted the fix/timeline-create-from-action branch July 20, 2020 14:14

This was referenced Jul 20, 2020

[7.x] [Security Solution][Timeline] Fix timeline styling and createFrom beh… (#72152) #72439

Merged

[7.9] [Security Solution][Timeline] Fix timeline styling and createFrom beh… (#72152) #72440

Merged

patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jul 20, 2020

[Security Solution][Timeline] Fix timeline styling and createFrom beh… (

5726ca7

elastic#72152)

patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jul 20, 2020

[Security Solution][Timeline] Fix timeline styling and createFrom beh… (

15f64a9

elastic#72152)

patrykkopycinski added a commit that referenced this pull request Jul 20, 2020

[Security Solution][Timeline] Fix timeline styling and createFrom beh… (

edc2f9d

#72152) (#72440)

patrykkopycinski added a commit that referenced this pull request Jul 20, 2020

[Security Solution][Timeline] Fix timeline styling and createFrom beh… (

a1fa046

#72152) (#72439)

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Timeline] Fix timeline styling and createFrom beh…#72152

[Security Solution][Timeline] Fix timeline styling and createFrom beh…#72152
patrykkopycinski merged 12 commits intoelastic:masterfrom
patrykkopycinski:fix/timeline-create-from-action

patrykkopycinski commented Jul 16, 2020

Uh oh!

elasticmachine commented Jul 16, 2020

Uh oh!

XavierM Jul 16, 2020

Uh oh!

patrykkopycinski commented Jul 17, 2020

Uh oh!

angorayc Jul 20, 2020

Uh oh!

angorayc Jul 20, 2020

Uh oh!

kibanamachine commented Jul 20, 2020

Uh oh!

stephmilovic commented Jul 20, 2020

Uh oh!

elasticmachine commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

patrykkopycinski commented Jul 16, 2020

Summary

Checklist

Uh oh!

elasticmachine commented Jul 16, 2020

Uh oh!

XavierM Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

patrykkopycinski commented Jul 17, 2020

Uh oh!

angorayc Jul 20, 2020

Choose a reason for hiding this comment

Uh oh!

angorayc Jul 20, 2020

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jul 20, 2020

💚 Build Succeeded

Build metrics

async chunks size

page load bundle size

History

Uh oh!

stephmilovic commented Jul 20, 2020

Uh oh!

elasticmachine commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants