Skip to content

[7.x] [Security Solution][Detections] Validate file type of value lists (#72746)#72771

Merged
rylnd merged 1 commit intoelastic:7.xfrom
rylnd:backport/7.x/pr-72746
Jul 22, 2020
Merged

[7.x] [Security Solution][Detections] Validate file type of value lists (#72746)#72771
rylnd merged 1 commit intoelastic:7.xfrom
rylnd:backport/7.x/pr-72746

Conversation

@rylnd
Copy link
Copy Markdown
Contributor

@rylnd rylnd commented Jul 21, 2020

Backports the following commits to 7.x:

…astic#72746)

* UI validates file type of uploaded value list

* file picker itself is restricted to text/csv and text/plain
* if they drag/drop an invalid file, we disable the upload button and
display an error message
* refactors form state to be a File instead of a FileList

* Refactor validation and error message in terms of file type

Instead of maintaining lists of both valid extensions and valid mime
types, we simply use the latter.
@rylnd rylnd added the backport This PR is a backport of another PR label Jul 21, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +853.0B 7.3MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd merged commit 9f3d99f into elastic:7.x Jul 22, 2020
@rylnd rylnd deleted the backport/7.x/pr-72746 branch July 22, 2020 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants