[Canvas][tech-debt] Refactor Layout Annotations (kill recompose.pure Part 2)#73305
Merged
clintandrewhall merged 2 commits intoelastic:masterfrom Jul 28, 2020
Merged
Conversation
clintandrewhall
added
review
Team:Presentation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
ryankeairns
reviewed
Jul 27, 2020
x-pack/plugins/canvas/public/components/layout_annotations/layout_annotations.scss
Outdated
Show resolved
Hide resolved
ryankeairns
approved these changes
Jul 27, 2020
Contributor
ryankeairns
left a comment
ryankeairns
left a comment
There was a problem hiding this comment.
Marking as approved since stuff is just being moved to another file. There is some future clean up that could happen here, as noted.
crob611
approved these changes
Jul 27, 2020
| width: number; | ||
| } | ||
|
|
||
| export const BorderConnection: FC<Props> = ({ transformMatrix, width, height }) => ( |
Contributor
There was a problem hiding this comment.
Question: A few of the annotations like this one get called frequently. Should we look into doing any memoization of these components? Or do you think the overhead of the memoization would outweigh any performance gains?
Contributor
Author
There was a problem hiding this comment.
That's not a bad idea. I'm not sure of the perf gain, but the rendering aspect could certainly weigh heavily. I'll test before committing.
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
clintandrewhall
added a commit
to clintandrewhall/kibana
that referenced
this pull request
Jul 28, 2020
clintandrewhall
added a commit
that referenced
this pull request
Jul 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While converting various layout annotations to remove the
pureHOC, I noticed they're 1/ all very alike, and 2/ spread out throughout thecomponentsdirectory. Seemed to make sense to combine them, (and their styles).This PR kills
recompose.pure, refactors the files and related CSS, and applies best practices.