Move painless lang support to @kbn/monaco

[alisonelizabeth]

This PR includes some refactoring of the @kbn/monaco package. I started this work in #80577, but decided to break it up as a separate PR as it affects the XJSON support.

• Created top-level folders for painless and esql languages, parallel to xjson. The painless language will eventually include autocomplete and error handling support (to be implemented in Support for painless language autocomplete within monaco #80577). I imagine we might at some point want to provide the same for esql too.
• Created a global.ts file that registers the languages and creates the web workers. There will eventually be a web worker for painless.
• Removed the languageService in painless_lab. AFAICT this is no longer necessary.

How to test

Verify there are no regressions in the XJSON support and syntax highlighting in painless lab. I'm fairly confident in the painless lab changes, but not so much for XJSON 😄 . I used the sample in #67485 to test, but there may be more use cases I should verify (in particular around esql support).

[alisonelizabeth]

As you can see, there are a few minor differences between the painless lexer rules in xjson (original code) and the lexer rules in painless lab (original code). I don't see why they would/should be different, but if there is a reason, please let me know.

[alisonelizabeth]

I noticed the xjson and painless languages were getting registered twice - once here (and in lexer_rules/xjson, respectively), and again in the registerLexerRules function. I assume this was a mistake, but wanted to call out here if not.

[elasticmachine]

Pinging @elastic/es-ui (Team:Elasticsearch UI)

[jloleysens]

Great work @alisonelizabeth ! I tested locally and everything seems to be working as expected!

I noticed this warning from Monaco when opening a page, like Painless lab, with a painless editor in it:

I think we need to re-introduce the behaviour of language_service.ts that did the following:

import workerSrc from 'raw-loader!monaco-editor/min/vs/base/worker/workerMain.js';
...
      (window as any).MonacoEnvironment = {	
        getWorker: () => {	
          const blob = new Blob([workerSrc], { type: 'application/javascript' });	
          return new Worker(window.URL.createObjectURL(blob));	
        },
...

In the global.ts file you created we should just add an if check for painless to suppress this warning. We also need to do this for Elasticsearch SQL esql.

One other thing that I want to get your thoughts on, non-blocking: I think renaming global.ts -> register_globals.ts and changing monaco.ts -> monaco_imports.ts might better communicate the intention behind these files. That way if I see import './reigster_globals' in the code it seems even clearer regarding the intention behind the file.

Overall these changes are looking great!

[alisonelizabeth]

Thanks @jloleysens for the review!

One other thing that I want to get your thoughts on, non-blocking: I think renaming global.ts -> register_globals.ts and changing monaco.ts -> monaco_imports.ts might better communicate the intention behind these files. That way if I see import './reigster_globals' in the code it seems even clearer regarding the intention behind the file.

👍 Good call. I went ahead and made this change. I think this is more explicit as well.

I noticed this warning from Monaco when opening a page, like Painless lab, with a painless editor in it:

Good catch! For some reason, I don't recall seeing the warnings when I was doing initial testing, which is why I removed it. This should be fixed now via ac180cc.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 3a33ac0

Metrics [docs]

@kbn/optimizer bundle module count

id	before	after	diff
painlessLab	40	35	-5

@kbn/ui-shared-deps asset size

id	before	after	diff
kbn-ui-shared-deps.@elastic.js	2.4MB	2.4MB	+8.0B
kbn-ui-shared-deps.js	4.7MB	4.8MB	+90.5KB
total			+90.5KB

async chunks size

id	before	after	diff
painlessLab	38.7KB	38.8KB	+104.0B

distributable file count

id	before	after	diff
default	48052	48060	+8
oss	28571	28579	+8

page load bundle size

id	before	after	diff
painlessLab	160.9KB	27.0KB	-133.9KB

History

• 💔 Build #82844 failed ac180cc
• 💚 Build #82481 succeeded 4496ec1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream