[Maps] show icon when layer is filtered by time and allow layers to ignore global time range by nreese · Pull Request #83006 · elastic/kibana

nreese · 2020-11-09T19:32:37Z

PR adds icon when layer is filtered by time

PR allows for turning off global time range for layer and joins

…gnore global time range

elasticmachine · 2020-11-09T19:32:39Z

Pinging @elastic/kibana-gis (Team:Geo)

elasticmachine · 2020-11-09T19:32:42Z

Pinging @elastic/apm-ui (Team:apm)

elasticmachine · 2020-11-09T19:32:42Z

Pinging @elastic/uptime (Team:uptime)

…lyGlobalTime

thomasneirynck

thx a lot, this is really useful imho. it will remove a lot of ambivalence, and help user troubleshoot their map. e.g. it's very common to hear "why aren't my results showing" because the timefilter is set by default at "-15m". It will also help with matching layers to geo-threshold jobs in the alerting framework. These geo-threshold jobs do not take into account the time-field for the boundary-layer. In those cases, it would not be possible to build maps that correspond to such a job-configuration.

...nected_components/widget_overlay/layer_control/layer_toc/toc_entry/toc_entry_button/index.ts

thomasneirynck · 2020-11-09T21:18:26Z

...nents/widget_overlay/layer_control/layer_toc/toc_entry/toc_entry_button/toc_entry_button.tsx

+          }),
+        });
+      }
+      if (this.state.isFilteredByGlobalTime) {


as discussed, this can toggle on/off directly when the flag turns on/off.

Fixed in a97a4cd

x-pack/plugins/maps/public/classes/layers/layer.tsx

thomasneirynck

thx!

lgtm when green

nreese · 2020-11-10T13:35:58Z

@elasticmachine merge upstream

kibanamachine · 2020-11-10T15:23:02Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 7fabe2d

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`maps`	620	623	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.2MB	3.2MB	+42.0B
`maps`	2.8MB	2.8MB	+7.3KB
total			+7.3KB

History

💚 Build #86945 succeeded a97a4cd
💔 Build #86930 failed 526d120
💔 Build #86908 failed 590b291

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…gnore global time range (elastic#83006) * [Maps] show icon when layer is filtered by time and allow layers to ignore global time range * show icon if layer is narrowed by time fitler * tslint * apply global time to source check box * apply global time to join check box * tslint and jest expect updates * one more tslint fix * tslint, fix apm jest test, update time filter icon when disabling applyGlobalTime Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…gnore global time range (#83006) (#83067) * [Maps] show icon when layer is filtered by time and allow layers to ignore global time range * show icon if layer is narrowed by time fitler * tslint * apply global time to source check box * apply global time to join check box * tslint and jest expect updates * one more tslint fix * tslint, fix apm jest test, update time filter icon when disabling applyGlobalTime Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…kibana into bootstrap-node-details-overlay * 'bootstrap-node-details-overlay' of github.com:phillipb/kibana: (49 commits) [Security Solution] Fix DNS Network table query (elastic#82778) [Workplace Search] Consolidate groups routes (elastic#83015) Adds cloud links to user menu (elastic#82803) [Security Solution][Detections] - follow up cleanup on auto refresh rules (elastic#83023) [App Search] Added the log retention panel to the Settings page (elastic#82982) [Maps] show icon when layer is filtered by time and allow layers to ignore global time range (elastic#83006) [DOCS] Consolidates drilldown pages (elastic#82081) [Maps] add on-prem EMS config (elastic#82525) migrate i18n mixin to KP (elastic#81799) [bundle optimization] fix imports of react-use lib (elastic#82847) [Discover] Add metric on adding filter (elastic#82961) [Lens] Performance refactoring for indexpattern fast lookup and Operation support matrix computation (elastic#82829) skip flaky suite (elastic#82804) Fix SO query for searching across spaces (elastic#83025) renaming built-in alerts to Stack Alerts (elastic#82873) [TSVB] Disable using top_hits in pipeline aggregations (elastic#82278) [Visualizations] Remove kui usage (elastic#82810) [Visualizations] Make the icon buttons labels more descriptive (elastic#82585) [Lens] Do not reset formatting when switching between custom ranges and auto histogram (elastic#82694) Fix ilm navigation (elastic#81664) ...

…na into alerts/stack-alerts-public * 'alerts/stack-alerts-public' of github.com:gmmorris/kibana: [Security Solution] Fix DNS Network table query (elastic#82778) [Workplace Search] Consolidate groups routes (elastic#83015) Adds cloud links to user menu (elastic#82803) [Security Solution][Detections] - follow up cleanup on auto refresh rules (elastic#83023) [App Search] Added the log retention panel to the Settings page (elastic#82982) [Maps] show icon when layer is filtered by time and allow layers to ignore global time range (elastic#83006) [DOCS] Consolidates drilldown pages (elastic#82081) [Maps] add on-prem EMS config (elastic#82525) migrate i18n mixin to KP (elastic#81799) [bundle optimization] fix imports of react-use lib (elastic#82847) [Discover] Add metric on adding filter (elastic#82961) [Lens] Performance refactoring for indexpattern fast lookup and Operation support matrix computation (elastic#82829) skip flaky suite (elastic#82804) Fix SO query for searching across spaces (elastic#83025) renaming built-in alerts to Stack Alerts (elastic#82873) [TSVB] Disable using top_hits in pipeline aggregations (elastic#82278) [Visualizations] Remove kui usage (elastic#82810) [Visualizations] Make the icon buttons labels more descriptive (elastic#82585) [Lens] Do not reset formatting when switching between custom ranges and auto histogram (elastic#82694) :

nreese added 6 commits November 5, 2020 14:35

[Maps] show icon when layer is filtered by time and allow layers to i…

84ccb80

…gnore global time range

show icon if layer is narrowed by time fitler

5726f07

tslint

06a13d7

Merge branch 'master' of github.com:elastic/kibana into applyGlobalTime

5765997

apply global time to source check box

dd1d0e5

apply global time to join check box

590b291

nreese added release_note:enhancement Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.11.0 labels Nov 9, 2020

nreese requested a review from thomasneirynck November 9, 2020 19:32

nreese requested review from a team as code owners November 9, 2020 19:32

botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Nov 9, 2020

nreese changed the title ~~@nreese [Maps] show icon when layer is filtered by time and allow layers to ignore global time range~~ [Maps] show icon when layer is filtered by time and allow layers to ignore global time range Nov 9, 2020

nreese added 3 commits November 9, 2020 13:18

tslint and jest expect updates

e8a5bd4

one more tslint fix

526d120

tslint, fix apm jest test, update time filter icon when disabling app…

a97a4cd

…lyGlobalTime

thomasneirynck reviewed Nov 9, 2020

View reviewed changes

nreese requested a review from thomasneirynck November 9, 2020 21:35

thomasneirynck approved these changes Nov 9, 2020

View reviewed changes

Merge branch 'master' into applyGlobalTime

7fabe2d

nreese merged commit 2332c8b into elastic:master Nov 10, 2020

nreese mentioned this pull request Nov 10, 2020

[7.x] [Maps] show icon when layer is filtered by time and allow layers to ignore global time range (#83006) #83067

Merged

nreese mentioned this pull request Nov 10, 2020

[Maps] Add time controls to layers #35658

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps] show icon when layer is filtered by time and allow layers to ignore global time range#83006

[Maps] show icon when layer is filtered by time and allow layers to ignore global time range#83006
nreese merged 10 commits intoelastic:masterfrom
nreese:applyGlobalTime

nreese commented Nov 9, 2020

Uh oh!

elasticmachine commented Nov 9, 2020

Uh oh!

elasticmachine commented Nov 9, 2020

Uh oh!

elasticmachine commented Nov 9, 2020

Uh oh!

thomasneirynck left a comment

Uh oh!

Uh oh!

thomasneirynck Nov 9, 2020

Uh oh!

nreese Nov 9, 2020

Uh oh!

Uh oh!

thomasneirynck left a comment •

edited

Loading

Uh oh!

nreese commented Nov 10, 2020

Uh oh!

kibanamachine commented Nov 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

nreese commented Nov 9, 2020

Uh oh!

elasticmachine commented Nov 9, 2020

Uh oh!

elasticmachine commented Nov 9, 2020

Uh oh!

elasticmachine commented Nov 9, 2020

Uh oh!

thomasneirynck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thomasneirynck Nov 9, 2020

Choose a reason for hiding this comment

Uh oh!

nreese Nov 9, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thomasneirynck left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nreese commented Nov 10, 2020

Uh oh!

kibanamachine commented Nov 10, 2020

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thomasneirynck left a comment •

edited

Loading