[ML] Persisted URL state for the "Anomaly detection jobs" page by darnautov · Pull Request #83149 · elastic/kibana

darnautov · 2020-11-11T09:01:33Z

Summary

Part of #83033

Adds persisted URL state on the Anomaly Detection jobs list page with the following parameters:

Selected filters
- Job Ids
- Group Ids
- Job state
- Datafeed state
Pagination
- Active page
- Page size
Sorting
- Sort field
- Sort direction

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2020-11-11T12:25:43Z

Pinging @elastic/ml-ui (:ml)

peteharverson

Tested in ML and LGTM.

Found what look like an unrelated issue where clicking on the Anomaly Detection breadcrumb clears the URL state but doesn't reset the filtering on the list:

elasticmachine · 2020-11-11T17:17:33Z

Pinging @elastic/apm-ui (Team:apm)

x-pack/plugins/apm/public/components/shared/Links/MachineLearningLinks/MLLink.test.tsx

sorenlouv

lgtm

afgomez · 2020-11-12T11:10:53Z

...plugins/infra/public/components/logging/log_analysis_setup/setup_flyout/module_list_card.tsx

+
+  const [viewInMlLink, setViewInMlLink] = useState<string>('');
+
+  const getMlUrl = async () => {


I think we can skip this check. If the ML module is not available I don't think the setup flyout will ever be mounted anyway.

afgomez · 2020-11-12T11:18:47Z

...plugins/infra/public/components/logging/log_analysis_setup/setup_flyout/module_list_card.tsx

+      });
+      return;
+    }
+    setViewInMlLink(await ml.urlGenerator.createUrl({ page: 'jobs', pageState: { jobId } }));


Unrelated to this PR but I'm curious: how come the createUrl() method is async? Does it fetch anything in the background to generate the URL?

It's a question for the Kibana team. Check the exposed public contract of the URL generator

kibana/src/plugins/share/public/url_generators/url_generator_internal.ts

Line 73 in 543481b

createUrl: async (state: UrlGeneratorStateMapping[Id]['State']) => {

walterra

LGTM, great work reducing the bundle size!

darnautov · 2020-11-12T11:34:30Z

@elasticmachine merge upstream

kibanamachine · 2020-11-12T13:21:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: cfc7474

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	2.5MB	2.5MB	+3.9KB
`ml`	6.7MB	4.5MB	-2.2MB
total			-2.2MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`infra`	174.0KB	174.3KB	+236.0B
`ml`	63.5KB	66.0KB	+2.5KB
total			+2.7KB

History

💚 Build #87554 succeeded 593cd83
💚 Build #87320 succeeded b48ab5b
💔 Build #87310 failed 8eebf80

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: [Advanced Settings] Introducing telemetry (elastic#82860) [alerts] add executionStatus to event log doc for action execute (elastic#82401) Add additional sources routes (elastic#83227) [ML] Persisted URL state for the "Anomaly detection jobs" page (elastic#83149) [Logs UI] Add pagination to the log stream shared component (elastic#81193) [Index Management] Add an index template link to data stream details (elastic#82592) Add maps_oss folder to code_owners (elastic#83204) fix truncation issue (elastic#83000) [Ingest Manger] Move asset getters out of registry (elastic#83214)

… (#83285) * [ML] table config in the URL state * [ML] fix job list on the management page * [ML] store query filter in the URL * [ML] fix context for the management page * [ML] update module_list_card.tsx in Logs UI * [ML] fix unit tests * [ML] fix unit tests * [ML] fix unit tests * [ML] move utils functions * [ML] url generator to support both job and group ids

… alerts/action-groups-as-conditions * origin/alerts/stack-alerts-public: (91 commits) removed import from plugin code as it causes FTR to fail [Advanced Settings] Introducing telemetry (elastic#82860) [alerts] add executionStatus to event log doc for action execute (elastic#82401) Add additional sources routes (elastic#83227) [ML] Persisted URL state for the "Anomaly detection jobs" page (elastic#83149) [Logs UI] Add pagination to the log stream shared component (elastic#81193) [Index Management] Add an index template link to data stream details (elastic#82592) Add maps_oss folder to code_owners (elastic#83204) fix truncation issue (elastic#83000) [Ingest Manger] Move asset getters out of registry (elastic#83214) make defaulted field non maybe Remove unused asciidoc file (elastic#83228) [Lens] Remove background from lens embeddable (elastic#83061) [Discover] Unskip flaky tests based on discover fixture index pattern (elastic#82991) Removing unnecessary trailing slash in CODEOWNERS Trying to fix CODEOWNERS again, where was a non-existent team prior (elastic#83236) Trying to fix CODEOWERS, missing a starting slash (elastic#83233) skip flaky suite (elastic#83231) Add enzyme rerender test helper (elastic#83208) Move Elasticsearch type definitions out of APM (elastic#83081) ...

darnautov added 4 commits November 10, 2020 14:03

[ML] table config in the URL state

0d20fb7

[ML] fix job list on the management page

eef12d0

[ML] store query filter in the URL

7dc9094

[ML] fix context for the management page

93f10ca

darnautov added release_note:enhancement :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 v7.11.0 labels Nov 11, 2020

darnautov requested review from peteharverson and walterra November 11, 2020 09:01

darnautov self-assigned this Nov 11, 2020

darnautov mentioned this pull request Nov 11, 2020

[ML] Persisted state in the URL, improve browser history navigation #83033

Closed

7 tasks

darnautov added 4 commits November 11, 2020 11:07

[ML] update module_list_card.tsx in Logs UI

e18103e

[ML] fix unit tests

2ca607b

[ML] fix unit tests

55556e3

[ML] fix unit tests

8eebf80

elastic deleted a comment from kibanamachine Nov 11, 2020

[ML] move utils functions

b48ab5b

darnautov marked this pull request as ready for review November 11, 2020 12:25

darnautov requested a review from afgomez November 11, 2020 12:44

peteharverson approved these changes Nov 11, 2020

View reviewed changes

botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Nov 11, 2020

darnautov requested a review from jgowdyelastic November 11, 2020 17:22

sorenlouv reviewed Nov 11, 2020

View reviewed changes

x-pack/plugins/apm/public/components/shared/Links/MachineLearningLinks/MLLink.test.tsx Outdated Show resolved Hide resolved

[ML] url generator to support both job and group ids

593cd83

darnautov requested a review from a team November 12, 2020 08:48

darnautov requested a review from a team as a code owner November 12, 2020 08:48

darnautov requested review from a team as code owners November 12, 2020 08:48

sorenlouv approved these changes Nov 12, 2020

View reviewed changes

afgomez approved these changes Nov 12, 2020

View reviewed changes

walterra approved these changes Nov 12, 2020

View reviewed changes

Merge branch 'master' into ML-83033-ad-list-url-state

cfc7474

XavierM approved these changes Nov 12, 2020

View reviewed changes

darnautov merged commit 169dcef into elastic:master Nov 12, 2020

darnautov deleted the ML-83033-ad-list-url-state branch November 12, 2020 14:16

darnautov mentioned this pull request Nov 12, 2020

[7.x] [ML] Persisted URL state for the "Anomaly detection jobs" page (#83149) #83285

Merged

jgowdyelastic mentioned this pull request Jul 7, 2021

[ML] Fix error handling in job search bar #104759

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Persisted URL state for the "Anomaly detection jobs" page#83149

[ML] Persisted URL state for the "Anomaly detection jobs" page#83149
darnautov merged 11 commits intoelastic:masterfrom
darnautov:ML-83033-ad-list-url-state

darnautov commented Nov 11, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Nov 11, 2020

Uh oh!

peteharverson left a comment

Uh oh!

elasticmachine commented Nov 11, 2020

Uh oh!

Uh oh!

sorenlouv left a comment

Uh oh!

afgomez Nov 12, 2020

Uh oh!

afgomez Nov 12, 2020

Uh oh!

darnautov Nov 12, 2020

Uh oh!

walterra left a comment

Uh oh!

darnautov commented Nov 12, 2020

Uh oh!

kibanamachine commented Nov 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants


		const [viewInMlLink, setViewInMlLink] = useState<string>('');

		const getMlUrl = async () => {

Conversation

darnautov commented Nov 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Nov 11, 2020

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 11, 2020

Uh oh!

Uh oh!

sorenlouv left a comment

Choose a reason for hiding this comment

Uh oh!

afgomez Nov 12, 2020

Choose a reason for hiding this comment

Uh oh!

afgomez Nov 12, 2020

Choose a reason for hiding this comment

Uh oh!

darnautov Nov 12, 2020

Choose a reason for hiding this comment

Uh oh!

walterra left a comment

Choose a reason for hiding this comment

Uh oh!

darnautov commented Nov 12, 2020

Uh oh!

kibanamachine commented Nov 12, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

darnautov commented Nov 11, 2020 •

edited

Loading